[PATCH 0/2] PID debugfs files

[PATCH 0/2] PID debugfs files

[Srinivas Pandruvada]

When PID is not used don't present PID parameters to tune.
Also update documentation.

Srinivas Pandruvada (2):
  cpufreq: intel_pstate: Remove PID debugfs when not used
  Documentation: intel_pstate: PID tuning is not always available

 Documentation/cpu-freq/intel-pstate.txt | 9 +++++----
 drivers/cpufreq/intel_pstate.c          | 4 +++-
 2 files changed, 8 insertions(+), 5 deletions(-)

-- 
2.7.4

[PATCH 1/2] cpufreq: intel_pstate: Remove PID debugfs when not used

[Srinivas Pandruvada]

When target state is calculated using get_target_pstate_use_cpu_load(),
PID controller is not used, hence it has no effect on performance.
So don't present debugfs entries to tune PID controller.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/cpufreq/intel_pstate.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 52cedd6..5725b85 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1844,7 +1844,9 @@ static int __init intel_pstate_init(void)
 	if (rc)
 		goto out;
 
-	intel_pstate_debug_expose_params();
+	if (pstate_funcs.get_target_pstate != get_target_pstate_use_cpu_load)
+		intel_pstate_debug_expose_params();
+
 	intel_pstate_sysfs_expose_params();
 
 	if (hwp_active)
-- 
2.7.4

[PATCH 2/2] Documentation: intel_pstate: PID tuning is not always available

[Srinivas Pandruvada]

PID tuning is not available when the get_target_pstate_use_cpu_load()
is used to calculate target_state. So update the documentation.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 Documentation/cpu-freq/intel-pstate.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
index e6bd1e6..5528d6d 100644
--- a/Documentation/cpu-freq/intel-pstate.txt
+++ b/Documentation/cpu-freq/intel-pstate.txt
@@ -122,11 +122,12 @@ will run at is selected by the processor itself.
 
 Tuning Intel P-State driver
 
-When HWP mode is not used, debugfs files have also been added to allow the
-tuning of the internal governor algorithm. These files are located at
-/sys/kernel/debug/pstate_snb/. The algorithm uses a PID (Proportional
-Integral Derivative) controller. The PID tunable parameters are:
+When the performance can be tuned using PID (Proportional Integral
+Derivative) controller, debugfs files are provided for adjusting performance.
+They are presented under:
+/sys/kernel/debug/pstate_snb/
 
+The PID tunable parameters are:
       deadband
       d_gain_pct
       i_gain_pct
-- 
2.7.4