* [PATCH] PM / sleep: fix device reference leak in test_suspend
@ 2016-11-01 10:49 Johan Hovold
2016-11-02 8:52 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2016-11-01 10:49 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Pavel Machek, Len Brown, linux-pm, linux-kernel, Johan Hovold
Make sure to drop the reference taken by class_find_device() after
opening the rtc device.
Fixes: 77437fd4e61f ("pm: boot time suspend selftest")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
kernel/power/suspend_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
index 084452e34a12..bdff5ed57f10 100644
--- a/kernel/power/suspend_test.c
+++ b/kernel/power/suspend_test.c
@@ -203,8 +203,10 @@ static int __init test_suspend(void)
/* RTCs have initialized by now too ... can we use one? */
dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
- if (dev)
+ if (dev) {
rtc = rtc_class_open(dev_name(dev));
+ put_device(dev);
+ }
if (!rtc) {
printk(warn_no_rtc);
return 0;
--
2.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / sleep: fix device reference leak in test_suspend
2016-11-01 10:49 [PATCH] PM / sleep: fix device reference leak in test_suspend Johan Hovold
@ 2016-11-02 8:52 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2016-11-02 8:52 UTC (permalink / raw)
To: Johan Hovold; +Cc: Rafael J. Wysocki, Len Brown, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
On Tue 2016-11-01 11:49:56, Johan Hovold wrote:
> Make sure to drop the reference taken by class_find_device() after
> opening the rtc device.
>
> Fixes: 77437fd4e61f ("pm: boot time suspend selftest")
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> kernel/power/suspend_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
> index 084452e34a12..bdff5ed57f10 100644
> --- a/kernel/power/suspend_test.c
> +++ b/kernel/power/suspend_test.c
> @@ -203,8 +203,10 @@ static int __init test_suspend(void)
>
> /* RTCs have initialized by now too ... can we use one? */
> dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
> - if (dev)
> + if (dev) {
> rtc = rtc_class_open(dev_name(dev));
> + put_device(dev);
> + }
> if (!rtc) {
> printk(warn_no_rtc);
> return 0;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-02 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-01 10:49 [PATCH] PM / sleep: fix device reference leak in test_suspend Johan Hovold
2016-11-02 8:52 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).