* [PATCH] tools/power turbostat: Disable HWP OOB status
@ 2016-11-11 22:14 Srinivas Pandruvada
2016-11-11 22:18 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Pandruvada @ 2016-11-11 22:14 UTC (permalink / raw)
To: lenb, rjw; +Cc: linux-pm, Srinivas Pandruvada
Display if the HWP is enabled in OOB (Out of band) mode.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
tools/power/x86/turbostat/turbostat.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 3e199b5..27fb0f0 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -3174,10 +3174,11 @@ void decode_misc_pwr_mgmt_msr(void)
return;
if (!get_msr(base_cpu, MSR_MISC_PWR_MGMT, &msr))
- fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx (%sable-EIST_Coordination %sable-EPB)\n",
+ fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx (%sable-EIST_Coordination %sable-EPB %sable-OOB)\n",
base_cpu, msr,
msr & (1 << 0) ? "DIS" : "EN",
- msr & (1 << 1) ? "EN" : "DIS");
+ msr & (1 << 1) ? "EN" : "DIS",
+ msr & (1 << 8) ? "EN" : "DIS");
}
void process_cpuid()
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/power turbostat: Disable HWP OOB status
2016-11-11 22:14 [PATCH] tools/power turbostat: Disable HWP OOB status Srinivas Pandruvada
@ 2016-11-11 22:18 ` Rafael J. Wysocki
2016-11-11 22:25 ` Srinivas Pandruvada
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-11-11 22:18 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: Len Brown, Rafael J. Wysocki, Linux PM
On Fri, Nov 11, 2016 at 11:14 PM, Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> Display if the HWP is enabled in OOB (Out of band) mode.
Hmm. Should the subject be "tools/power turbostat: Display HWP OOB status"?
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> tools/power/x86/turbostat/turbostat.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 3e199b5..27fb0f0 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -3174,10 +3174,11 @@ void decode_misc_pwr_mgmt_msr(void)
> return;
>
> if (!get_msr(base_cpu, MSR_MISC_PWR_MGMT, &msr))
> - fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx (%sable-EIST_Coordination %sable-EPB)\n",
> + fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx (%sable-EIST_Coordination %sable-EPB %sable-OOB)\n",
> base_cpu, msr,
> msr & (1 << 0) ? "DIS" : "EN",
> - msr & (1 << 1) ? "EN" : "DIS");
> + msr & (1 << 1) ? "EN" : "DIS",
> + msr & (1 << 8) ? "EN" : "DIS");
> }
>
> void process_cpuid()
> --
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/power turbostat: Disable HWP OOB status
2016-11-11 22:18 ` Rafael J. Wysocki
@ 2016-11-11 22:25 ` Srinivas Pandruvada
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2016-11-11 22:25 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, Rafael J. Wysocki, Linux PM
On Fri, 2016-11-11 at 23:18 +0100, Rafael J. Wysocki wrote:
> On Fri, Nov 11, 2016 at 11:14 PM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> >
> > Display if the HWP is enabled in OOB (Out of band) mode.
>
> Hmm. Should the subject be "tools/power turbostat: Display HWP OOB
> status"?
yikes. I don't know how I wrote this. This should be "Display" instead
of "Disable"
Thanks,
Srinivas
>
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel
> > .com>
> > ---
> > tools/power/x86/turbostat/turbostat.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/power/x86/turbostat/turbostat.c
> > b/tools/power/x86/turbostat/turbostat.c
> > index 3e199b5..27fb0f0 100644
> > --- a/tools/power/x86/turbostat/turbostat.c
> > +++ b/tools/power/x86/turbostat/turbostat.c
> > @@ -3174,10 +3174,11 @@ void decode_misc_pwr_mgmt_msr(void)
> > return;
> >
> > if (!get_msr(base_cpu, MSR_MISC_PWR_MGMT, &msr))
> > - fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx
> > (%sable-EIST_Coordination %sable-EPB)\n",
> > + fprintf(outf, "cpu%d: MSR_MISC_PWR_MGMT: 0x%08llx
> > (%sable-EIST_Coordination %sable-EPB %sable-OOB)\n",
> > base_cpu, msr,
> > msr & (1 << 0) ? "DIS" : "EN",
> > - msr & (1 << 1) ? "EN" : "DIS");
> > + msr & (1 << 1) ? "EN" : "DIS",
> > + msr & (1 << 8) ? "EN" : "DIS");
> > }
> >
> > void process_cpuid()
> > --
>
> Thanks,
> Rafael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-11 22:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-11 22:14 [PATCH] tools/power turbostat: Disable HWP OOB status Srinivas Pandruvada
2016-11-11 22:18 ` Rafael J. Wysocki
2016-11-11 22:25 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).