linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Set EPP/EPB to 0 in performance mode
Date: Mon, 21 Nov 2016 09:27:18 -0800	[thread overview]
Message-ID: <1479749238.6544.147.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0iC2MesdO58+d1J4u1F5UYGtcPZArXWkiY5cptF=bxntw@mail.gmail.com>

On Sat, 2016-11-19 at 00:26 +0100, Rafael J. Wysocki wrote:
> On Fri, Nov 18, 2016 at 4:15 AM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:

[...]

> > +                       if (cpu_data->policy ==
> > CPUFREQ_POLICY_PERFORMANCE) {
> 
> Why don't we simply save the EPP/EPB here, ->

We can, but we loose the ability to restore to the default power on
configuration. For other control limits, users have ability to look at
the sysfs and set the limits back to power on default. Since we don't
have any other way to look at go back to default EPP, once save and
restore. So if this behavior is not important, then this can be done.

Thanks,
Srinivas

  reply	other threads:[~2016-11-21 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  3:15 [PATCH] cpufreq: intel_pstate: Set EPP/EPB to 0 in performance mode Srinivas Pandruvada
2016-11-18 23:26 ` Rafael J. Wysocki
2016-11-21 17:27   ` Srinivas Pandruvada [this message]
2016-11-21 20:57     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479749238.6544.147.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).