linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2] cpufreq: intel_pstate: Set EPP/EPB to 0 in performance mode
Date: Tue, 22 Nov 2016 17:20:22 -0800	[thread overview]
Message-ID: <1479864022.20426.12.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0h5Qx-_p2wfAqDjEt4jQ6h86mHCSfuRaewqumGgONGidQ@mail.gmail.com>

On Wed, 2016-11-23 at 01:53 +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 23, 2016 at 1:42 AM, Rafael J. Wysocki <rafael@kernel.org
> > wrote:
> > 
> > 
[...]

> > > invalid */
> > > +                       if (cpu_data->epp_saved < 0)
> > > +                               goto skip_epp;
> > > +
> This can be avoided too I suppose if epp_saved is initialized with
> the
> initial value of the EPP.
This is not only for initialization, but transient MSR read failures
later (which shouldn't happen, but for the completeness). So if you
weren't able to read for some unknown reason, then you shouldn't
restore.

Thanks,
Srinivas

> 
> Thanks,
> Rafael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-11-23  1:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 23:44 [PATCH v2] cpufreq: intel_pstate: Set EPP/EPB to 0 in performance mode Srinivas Pandruvada
2016-11-23  0:42 ` Rafael J. Wysocki
2016-11-23  0:53   ` Rafael J. Wysocki
2016-11-23  1:20     ` Srinivas Pandruvada [this message]
2016-11-23  1:41       ` Rafael J. Wysocki
2016-11-23  1:16   ` Srinivas Pandruvada
2016-11-23  1:41     ` Rafael J. Wysocki
2016-11-23  1:37       ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479864022.20426.12.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).