From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Pandruvada Subject: Re: [PATCH v2] cpufreq: intel_pstate: Set EPP/EPB to 0 in performance mode Date: Tue, 22 Nov 2016 17:20:22 -0800 Message-ID: <1479864022.20426.12.camel@linux.intel.com> References: <1479858269-175501-1-git-send-email-srinivas.pandruvada@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:12994 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756070AbcKWBXQ (ORCPT ); Tue, 22 Nov 2016 20:23:16 -0500 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" Cc: Len Brown , "Rafael J. Wysocki" , Linux PM On Wed, 2016-11-23 at 01:53 +0100, Rafael J. Wysocki wrote: > On Wed, Nov 23, 2016 at 1:42 AM, Rafael J. Wysocki > wrote: > > > > [...] > > > invalid */ > > > +                       if (cpu_data->epp_saved < 0) > > > +                               goto skip_epp; > > > + > This can be avoided too I suppose if epp_saved is initialized with > the > initial value of the EPP. This is not only for initialization, but transient MSR read failures later (which shouldn't happen, but for the completeness). So if you weren't able to read for some unknown reason, then you shouldn't restore. Thanks, Srinivas > > Thanks, > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html