Re: [PATCH 2/8] arm64: dts: exynos: Add GSCL power domain to Exynos 5433 SoC

Marek Szyprowski
2017-01-27T11:05:50Z

Hi Krzysztof,

On 2017-01-27 08:46, Krzysztof Kozlowski wrote:
> On Wed, Jan 25, 2017 at 12:55:36PM +0100, Marek Szyprowski wrote:
>> This patch adds support for GSCL power domain to Exynos 5433 SoCs, which
>> contains following devices: a clock controller, three GSCL video scalers and
>> their SYSMMUs.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> index 16072c1c3ed3..74c767d756ac 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> @@ -425,6 +425,7 @@
>> clocks = <&xxti>,
>> <&cmu_top CLK_ACLK_GSCL_111>,
>> <&cmu_top CLK_ACLK_GSCL_333>;
>> + power-domains = <&pd_gscl>;
>> };
>>
>> cmu_apollo: clock-controller@11900000 {
>> @@ -525,6 +526,12 @@
>> <&cmu_top CLK_ACLK_CAM1_552>;
>> };
>>
>> + pd_gscl: gscl-power-domain@105c4000 {
> The name of node: just "power-domain". This should be generic class of
> device (following ePAPR).
>
> The same applies to other patches.

Well, this makes the debugging much harder, but I will change it to generic
names. Also existing Exynos dtsi should be fixed in this area (Exynos4 still
use such more descriptive names). I will check how hard is to add real
domain names directly to the Exynos power domain driver then.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland