Re: [PATCH 2/8] arm64: dts: exynos: Add GSCL power domain to Exynos 5433 SoC

Krzysztof Kozlowski
2017-01-27T11:28:43Z

On Fri, Jan 27, 2017 at 11:33:36AM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 2017-01-27 08:46, Krzysztof Kozlowski wrote:
> > On Wed, Jan 25, 2017 at 12:55:36PM +0100, Marek Szyprowski wrote:
> > > This patch adds support for GSCL power domain to Exynos 5433 SoCs, which
> > > contains following devices: a clock controller, three GSCL video scalers and
> > > their SYSMMUs.
> > >
> > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > > ---
> > > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> > > index 16072c1c3ed3..74c767d756ac 100644
> > > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> > > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> > > @@ -425,6 +425,7 @@
> > > clocks = <&xxti>,
> > > <&cmu_top CLK_ACLK_GSCL_111>,
> > > <&cmu_top CLK_ACLK_GSCL_333>;
> > > + power-domains = <&pd_gscl>;
> > > };
> > > cmu_apollo: clock-controller@11900000 {
> > > @@ -525,6 +526,12 @@
> > > <&cmu_top CLK_ACLK_CAM1_552>;
> > > };
> > > + pd_gscl: gscl-power-domain@105c4000 {
> > The name of node: just "power-domain". This should be generic class of
> > device (following ePAPR).
> >
> > The same applies to other patches.
>
> Well, this makes the debugging much harder, but I will change it to generic
> names.

Good point. I remember some patch from Javier trying to address this but
I cannot find it anymore.

Anyway, I don't think power-domains should be treated here differently
then rest of devices (which have generic names: clock-controller,
pinctrl, i2s, i2c etc).

> Also existing Exynos dtsi should be fixed in this area (Exynos4 still
> use such more descriptive names).

I am trying to bring some shape to new code but of course you are right
- old code should be adjusted as well (maybe as part of some bigger
cleanup). Exynos5420 uses short/generic names.

> I will check how hard is to add real
> domain names directly to the Exynos power domain driver then.

Thanks!

Krzysztof