From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: Unreliable hibernation on Lenovo x230 (regression) Date: Tue, 07 Apr 2015 01:28:04 +0200 Message-ID: <1485724.gKixXC7XHQ@vostro.rjw.lan> References: <20150401214743.20fbe2c5@porcupinefactory.org> <3344848.SIHh1OazTO@vostro.rjw.lan> <20150405072613.GD27614@linux-rxt1.site> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:59143 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752673AbbDFXDn (ORCPT ); Mon, 6 Apr 2015 19:03:43 -0400 In-Reply-To: <20150405072613.GD27614@linux-rxt1.site> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: joeyli Cc: rhn , Pavel Machek , kernel list , joeyli.kernel@gmail.com, linux-pm@vger.kernel.org On Sunday, April 05, 2015 03:26:13 PM joeyli wrote: > On Fri, Apr 03, 2015 at 11:43:30PM +0200, Rafael J. Wysocki wrote: > > On Friday, April 03, 2015 05:58:25 PM rhn wrote: > > > On Thu, 2 Apr 2015 17:28:05 +0200 > > > Pavel Machek wrote: > > > > > > > On Wed 2015-04-01 21:47:43, rhn wrote: > > > > > Hello, > > > > > > > > > > Between kernel 3.16 and 3.17, a regression has been introduced where the first hibernation after regular shutdown always fails to resume. Subsequent hibernations succeed. > > > > > > > > > > The system is a Lenovo x230 with Intel i5, booting with EFI, with the hibernate partition located on a secondary SSD drive. Installed system is Fedora 20, hibernation and reboots were issued using the KDE shutdown dialog. > > > > > > > > > > I have tracked the problem to first appear in the commit > > > > > e67ee10190e69332f929bdd6594a312363321a66 Merge branches 'pm-sleep', 'pm-cpufreq' and 'pm-cpuidle' > > > > > > > > > > The problem itself manifests in dmesg as follows (system was first > > > > > restarted, then hibernated - this log is from the subsequent > > > > resume): > > > > > > > > Ok, can you try to disable cpufreq and cpuidle, and then try if it > > > > reproduces? > > > > > > > > At that point, this is the candidate: > > > > > > > > commit e67ee10190e69332f929bdd6594a312363321a66 > > > > Merge: 21c806d 84c91b7 39c8bba 372ba8c > > > > Author: Rafael J. Wysocki > > > > Date: Mon Aug 11 23:19:48 2014 +0200 > > > > > > > > Merge branches 'pm-sleep', 'pm-cpufreq' and 'pm-cpuidle' > > > > > > > > * pm-sleep: > > > > PM / hibernate: avoid unsafe pages in e820 reserved regions > > > > > > > > ... > > > > Alternatively, you can just try to revert > > > > > > > > commit 84c91b7ae07c62cf6dee7fde3277f4be21331f85 > > > > Author: Lee, Chun-Yi > > > > Date: Mon Aug 4 23:23:21 2014 +0800 > > > > > > > > PM / hibernate: avoid unsafe pages in e820 reserved regions > > > > > > > > When the machine doesn't well handle the e820 persistent when > > > > hibernate > > > > resuming, then it may cause page fault when writing image to > > > > snapshot > > > > buffer: > > > > > > > > > > > > ... > > > > > > > > Thanks, > > > > Pavel > > > > > > I tried to disable CONFIG_CPU_IDLE and CONFIG_CPU_FREQ, however for some reason I could only disable CONFIG_CPU_FREQ. > > > > > > The bug persisted. > > > > > > Reverting the commit 84c91b7 on top of e67ee10 fixes the problem. > > > > > > I created a copy of the bug report here: https://bugzilla.kernel.org/show_bug.cgi?id=96111 > > > > Please check if 4.0-rc6 still has the problem and if reverting the commit in > > question on top of it fixes the problem too. > > > > > > I think just revert 84c91b7ae until Yinghai Lu's patches merged to v4.1. > I will resend 84c91b7ae patch until Yinghai Lu's patches merged. OK, I'll queue up a revert of 84c91b7ae as a fix for 4.0. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.