From: Patrick Bellasi <patrick.bellasi@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: [RFC v3 5/5] sched/{core,cpufreq_schedutil}: add capacity clamping for RT/DL tasks
Date: Tue, 28 Feb 2017 14:38:42 +0000 [thread overview]
Message-ID: <1488292722-19410-6-git-send-email-patrick.bellasi@arm.com> (raw)
In-Reply-To: <1488292722-19410-1-git-send-email-patrick.bellasi@arm.com>
Currently schedutil enforce a maximum OPP when RT/DL tasks are RUNNABLE.
Such a mandatory policy can be made more tunable from userspace thus
allowing for example to define a reasonable max capacity (i.e.
frequency) which is required for the execution of a specific RT/DL
workload. This will contribute to make the RT class more "friendly" for
power/energy sensible applications.
This patch extends the usage of capacity_{min,max} to the RT/DL classes.
Whenever a task in these classes is RUNNABLE, the capacity required is
defined by the constraints of the control group that task belongs to.
Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org
---
kernel/sched/cpufreq_schedutil.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 51484f7..18abd62 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -256,7 +256,9 @@ static void sugov_update_single(struct update_util_data *hook, u64 time,
return;
if (flags & SCHED_CPUFREQ_RT_DL) {
- next_f = policy->cpuinfo.max_freq;
+ util = cap_clamp_cpu_util(smp_processor_id(),
+ SCHED_CAPACITY_SCALE);
+ next_f = get_next_freq(sg_cpu, util, policy->cpuinfo.max_freq);
} else {
sugov_get_util(&util, &max);
sugov_iowait_boost(sg_cpu, &util, &max);
@@ -272,15 +274,11 @@ static unsigned int sugov_next_freq_shared(struct sugov_cpu *sg_cpu,
{
struct sugov_policy *sg_policy = sg_cpu->sg_policy;
struct cpufreq_policy *policy = sg_policy->policy;
- unsigned int max_f = policy->cpuinfo.max_freq;
u64 last_freq_update_time = sg_policy->last_freq_update_time;
unsigned int cap_max = SCHED_CAPACITY_SCALE;
unsigned int cap_min = 0;
unsigned int j;
- if (flags & SCHED_CPUFREQ_RT_DL)
- return max_f;
-
sugov_iowait_boost(sg_cpu, &util, &max);
/* Initialize clamping range based on caller CPU constraints */
@@ -308,10 +306,11 @@ static unsigned int sugov_next_freq_shared(struct sugov_cpu *sg_cpu,
j_sg_cpu->iowait_boost = 0;
continue;
}
- if (j_sg_cpu->flags & SCHED_CPUFREQ_RT_DL)
- return max_f;
- j_util = j_sg_cpu->util;
+ if (j_sg_cpu->flags & SCHED_CPUFREQ_RT_DL)
+ j_util = cap_clamp_cpu_util(j, SCHED_CAPACITY_SCALE);
+ else
+ j_util = j_sg_cpu->util;
j_max = j_sg_cpu->max;
if (j_util * max > j_max * util) {
util = j_util;
--
2.7.4
next prev parent reply other threads:[~2017-02-28 14:49 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 14:38 [RFC v3 0/5] Add capacity capping support to the CPU controller Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 1/5] sched/core: add capacity constraints to " Patrick Bellasi
2017-03-13 10:46 ` Joel Fernandes (Google)
2017-03-15 11:20 ` Patrick Bellasi
2017-03-15 13:20 ` Joel Fernandes
2017-03-15 16:10 ` Paul E. McKenney
2017-03-15 16:44 ` Patrick Bellasi
2017-03-15 17:24 ` Paul E. McKenney
2017-03-15 17:57 ` Patrick Bellasi
2017-03-20 17:15 ` Tejun Heo
2017-03-20 17:36 ` Tejun Heo
2017-03-20 18:08 ` Patrick Bellasi
2017-03-23 0:28 ` Joel Fernandes (Google)
2017-03-23 10:32 ` Patrick Bellasi
2017-03-23 16:01 ` Tejun Heo
2017-03-23 18:15 ` Patrick Bellasi
2017-03-23 18:39 ` Tejun Heo
2017-03-24 6:37 ` Joel Fernandes (Google)
2017-03-24 15:00 ` Tejun Heo
2017-03-30 21:13 ` Paul Turner
2017-03-24 7:02 ` Joel Fernandes (Google)
2017-03-30 21:15 ` Paul Turner
2017-04-01 16:25 ` Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 2/5] sched/core: track CPU's capacity_{min,max} Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 3/5] sched/core: sync capacity_{min,max} between slow and fast paths Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 4/5] sched/{core,cpufreq_schedutil}: add capacity clamping for FAIR tasks Patrick Bellasi
2017-02-28 14:38 ` Patrick Bellasi [this message]
2017-03-13 10:08 ` [RFC v3 5/5] sched/{core,cpufreq_schedutil}: add capacity clamping for RT/DL tasks Joel Fernandes (Google)
2017-03-15 11:40 ` Patrick Bellasi
2017-03-15 12:59 ` Joel Fernandes
2017-03-15 14:44 ` Juri Lelli
2017-03-15 16:13 ` Joel Fernandes
2017-03-15 16:24 ` Juri Lelli
2017-03-15 23:40 ` Joel Fernandes
2017-03-16 11:16 ` Juri Lelli
2017-03-16 12:27 ` Patrick Bellasi
2017-03-16 12:44 ` Juri Lelli
2017-03-16 16:58 ` Joel Fernandes
2017-03-16 17:17 ` Juri Lelli
2017-03-15 11:41 ` [RFC v3 0/5] Add capacity capping support to the CPU controller Rafael J. Wysocki
2017-03-15 12:59 ` Patrick Bellasi
2017-03-16 1:04 ` Rafael J. Wysocki
2017-03-16 3:15 ` Joel Fernandes
2017-03-20 22:51 ` Rafael J. Wysocki
2017-03-21 11:01 ` Patrick Bellasi
2017-03-24 23:52 ` Rafael J. Wysocki
2017-03-16 12:23 ` Patrick Bellasi
2017-03-20 14:51 ` Tejun Heo
2017-03-20 17:22 ` Patrick Bellasi
2017-04-10 7:36 ` Peter Zijlstra
2017-04-11 17:58 ` Patrick Bellasi
2017-04-12 12:10 ` Peter Zijlstra
2017-04-12 13:55 ` Patrick Bellasi
2017-04-12 15:37 ` Peter Zijlstra
2017-04-13 11:33 ` Patrick Bellasi
2017-04-12 12:15 ` Peter Zijlstra
2017-04-12 13:34 ` Patrick Bellasi
2017-04-12 14:41 ` Peter Zijlstra
2017-04-12 12:22 ` Peter Zijlstra
2017-04-12 13:24 ` Patrick Bellasi
2017-04-12 12:48 ` Peter Zijlstra
2017-04-12 13:27 ` Patrick Bellasi
2017-04-12 14:34 ` Peter Zijlstra
2017-04-12 14:43 ` Patrick Bellasi
2017-04-12 16:14 ` Peter Zijlstra
2017-04-13 10:34 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488292722-19410-6-git-send-email-patrick.bellasi@arm.com \
--to=patrick.bellasi@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).