From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 1/4] acpi: battery: Add acpi_battery_unregister() function Date: Mon, 20 Mar 2017 15:10:00 +0200 Message-ID: <1490015400.19767.109.camel@linux.intel.com> References: <20170316161601.32267-1-hdegoede@redhat.com> <20170316161601.32267-2-hdegoede@redhat.com> <1489681793.19767.21.camel@linux.intel.com> <84d31794-d5c5-6f09-bbdb-9f5612ddbbbe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:53291 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbdCTNMd (ORCPT ); Mon, 20 Mar 2017 09:12:33 -0400 In-Reply-To: <84d31794-d5c5-6f09-bbdb-9f5612ddbbbe@redhat.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Hans de Goede , "Rafael J . Wysocki" , Len Brown , Sebastian Reichel , Chen-Yu Tsai Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org On Mon, 2017-03-20 at 14:03 +0100, Hans de Goede wrote: > Hi, > > Thank you for the reviews! > > On 16-03-17 17:29, Andy Shevchenko wrote: > > On Thu, 2017-03-16 at 17:15 +0100, Hans de Goede wrote: > > > @@ -31,6 +31,7 @@ > > >  #include > > >  #include > > >  #include > > > +#include > > > > Keep in alphabetical order ? > > I'm a fan of having headers in alphabetical order myself, > but if you look at the actual file, rather then the diff > context, you will see that this file uses random order. Okay, but can you squeeze it in most ordered part? > > > +++ b/include/linux/power/acpi.h > > > > E.g. for GPIO we keep such things directly in linux/acpi.h. Does it > > make > > sense to have separate one in this case? > > I've taken include/acpi/video.h as example here. TBH I do not think > shoving everything acpi related into linux/acpi.h is a good idea. So, let Rafael judge then. I have no strong opinion, just recall that case. -- Andy Shevchenko Intel Finland Oy