* [PATCH 1/1] power: check return value of devm_kzalloc
@ 2017-04-23 9:03 Pan Bian
2017-04-23 19:44 ` Pali Rohár
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2017-04-23 9:03 UTC (permalink / raw)
To: Pali Rohár, Sebastian Reichel; +Cc: linux-pm, linux-kernel, Pan Bian
Function devm_kzalloc() will return a NULL pointer if there is no enough
memory. However, in function isp1704_charger_probe(), the return value
of devm_kzalloc() is used without validation. This may result in a bad
memory access bug. This patch fixes the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/power/supply/isp1704_charger.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c
index 4cd6899..4dd2482 100644
--- a/drivers/power/supply/isp1704_charger.c
+++ b/drivers/power/supply/isp1704_charger.c
@@ -418,6 +418,8 @@ static int isp1704_charger_probe(struct platform_device *pdev)
pdata = devm_kzalloc(&pdev->dev,
sizeof(struct isp1704_charger_data), GFP_KERNEL);
+ if (!pdata)
+ return -ENOMEM;
pdata->enable_gpio = gpio;
dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] power: check return value of devm_kzalloc
2017-04-23 9:03 [PATCH 1/1] power: check return value of devm_kzalloc Pan Bian
@ 2017-04-23 19:44 ` Pali Rohár
0 siblings, 0 replies; 2+ messages in thread
From: Pali Rohár @ 2017-04-23 19:44 UTC (permalink / raw)
To: Pan Bian; +Cc: Sebastian Reichel, linux-pm, linux-kernel
[-- Attachment #1: Type: Text/Plain, Size: 467 bytes --]
On Sunday 23 April 2017 11:03:56 Pan Bian wrote:
> pdata = devm_kzalloc(&pdev->dev,
> sizeof(struct isp1704_charger_data), GFP_KERNEL);
> + if (!pdata)
> + return -ENOMEM;
> pdata->enable_gpio = gpio;
>
> dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
What about calling "goto fail0", so there will be error message about
failure of registering isp1704 like for any other failures?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-23 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-23 9:03 [PATCH 1/1] power: check return value of devm_kzalloc Pan Bian
2017-04-23 19:44 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).