From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x Date: Wed, 06 Aug 2014 22:35:46 +0200 Message-ID: <1494298.av10nJMuYA@vostro.rjw.lan> References: <1407300108-32186-1-git-send-email-hans@hanshq.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:63155 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752343AbaHFURF (ORCPT ); Wed, 6 Aug 2014 16:17:05 -0400 In-Reply-To: <1407300108-32186-1-git-send-email-hans@hanshq.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Hans Wennborg Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On Tuesday, August 05, 2014 09:41:48 PM Hans Wennborg wrote: > The prefix suggests the number should be printed in hex, so use > the %x specifier to do that. > > Found by using regex suggested by Joe Perches. > > Signed-off-by: Hans Wennborg This triggers a build warning related to the formats. Care to fix up? > --- > drivers/cpufreq/speedstep-smi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c > index 8635eec..fda9beb 100644 > --- a/drivers/cpufreq/speedstep-smi.c > +++ b/drivers/cpufreq/speedstep-smi.c > @@ -324,8 +324,8 @@ static int __init speedstep_init(void) > return -ENODEV; > } > > - pr_debug("signature:0x%.8ulx, command:0x%.8ulx, " > - "event:0x%.8ulx, perf_level:0x%.8ulx.\n", > + pr_debug("signature:0x%.8lx, command:0x%.8lx, " > + "event:0x%.8lx, perf_level:0x%.8lx.\n", > ist_info.signature, ist_info.command, > ist_info.event, ist_info.perf_level); > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.