* [PATCH] PowerCap: Fix an error code in powercap_register_zone()
@ 2017-05-10 19:40 Dan Carpenter
2017-05-11 1:41 ` Srinivas Pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-05-10 19:40 UTC (permalink / raw)
To: Rafael J. Wysocki, Srinivas Pandruvada; +Cc: linux-pm, kernel-janitors
In the current code we accidentally return the successful result from
idr_alloc() instead of a negative error pointer. The caller is looking
for an error pointer and so it treats the returned value as a valid
pointer.
This one might be a bit serious because if it lets people get around the
kernel's protection for remapping NULL. I'm not sure.
Fixes: 75d2364ea0ca ("PowerCap: Add class driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
index 14bde0db8c24..5b10b50f8686 100644
--- a/drivers/powercap/powercap_sys.c
+++ b/drivers/powercap/powercap_sys.c
@@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_zone(
power_zone->id = result;
idr_init(&power_zone->idr);
+ result = -ENOMEM;
power_zone->name = kstrdup(name, GFP_KERNEL);
if (!power_zone->name)
goto err_name_alloc;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PowerCap: Fix an error code in powercap_register_zone()
2017-05-10 19:40 [PATCH] PowerCap: Fix an error code in powercap_register_zone() Dan Carpenter
@ 2017-05-11 1:41 ` Srinivas Pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Pandruvada @ 2017-05-11 1:41 UTC (permalink / raw)
To: Dan Carpenter, Rafael J. Wysocki; +Cc: linux-pm, kernel-janitors
On Wed, 2017-05-10 at 22:40 +0300, Dan Carpenter wrote:
> In the current code we accidentally return the successful result from
> idr_alloc() instead of a negative error pointer. The caller is
> looking
> for an error pointer and so it treats the returned value as a valid
> pointer.
>
> This one might be a bit serious because if it lets people get around
> the
> kernel's protection for remapping NULL. I'm not sure.
>
> Fixes: 75d2364ea0ca ("PowerCap: Add class driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> diff --git a/drivers/powercap/powercap_sys.c
> b/drivers/powercap/powercap_sys.c
> index 14bde0db8c24..5b10b50f8686 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_zone(
>
> power_zone->id = result;
> idr_init(&power_zone->idr);
> + result = -ENOMEM;
> power_zone->name = kstrdup(name, GFP_KERNEL);
> if (!power_zone->name)
> goto err_name_alloc;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-11 1:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-10 19:40 [PATCH] PowerCap: Fix an error code in powercap_register_zone() Dan Carpenter
2017-05-11 1:41 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).