From: Shuah Khan <skhan@linuxfoundation.org>
To: Li kunyu <kunyu@nfschina.com>,
trenn@suse.com, shuah@kernel.org, ray.huang@amd.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] power: cpupower: utils: Optimize print_online_cpus and print_offline_cpus function
Date: Wed, 12 Oct 2022 09:39:56 -0600 [thread overview]
Message-ID: <14d690a4-d2d5-01db-b2a2-e3c87b4a6394@linuxfoundation.org> (raw)
In-Reply-To: <20221012101039.3142-1-kunyu@nfschina.com>
On 10/12/22 04:10, Li kunyu wrote:
> 1. Remove the initialization assignment of variables, and they will be
> assigned first.
> 2. Remove the mandatory conversion of returned value of malloc function,
> which returns void* type.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
Can you tell me more about why this change is needed and how you determined
the need for this change?
thanks,
-- Shuah
next prev parent reply other threads:[~2022-10-12 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 10:10 [PATCH] power: cpupower: utils: Optimize print_online_cpus and print_offline_cpus function Li kunyu
2022-10-12 15:39 ` Shuah Khan [this message]
2022-10-13 1:49 ` Li kunyu
2022-10-13 2:01 ` [PATCH] power: cpupower: utils: Optimize print_online_cpus and print_offline_cpus function Li kunyu
2022-10-13 15:58 ` Shuah Khan
2022-10-14 3:49 ` Li kunyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14d690a4-d2d5-01db-b2a2-e3c87b4a6394@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kunyu@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox