* [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies
@ 2017-07-21 16:16 Arnd Bergmann
2017-07-29 19:22 ` Pandruvada, Srinivas
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-07-21 16:16 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin; +Cc: Arnd Bergmann, linux-pm, linux-kernel
We get a Kconfig warning when selecting this without also enabling
CONFIG_PCI:
warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects IOSF_MBI which has unmet direct dependencies (PCI)
This adds a new depedency.
Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common APIs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/thermal/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index b5b5facb8747..ac2a53823576 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
config INTEL_SOC_DTS_IOSF_CORE
tristate
- depends on X86
+ depends on X86 && PCI
select IOSF_MBI
help
This is becoming a common feature for Intel SoCs to expose the additional
@@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
config INTEL_SOC_DTS_THERMAL
tristate "Intel SoCs DTS thermal driver"
- depends on X86
+ depends on X86 && PCI
select INTEL_SOC_DTS_IOSF_CORE
select THERMAL_WRITABLE_TRIPS
help
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies
2017-07-21 16:16 [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies Arnd Bergmann
@ 2017-07-29 19:22 ` Pandruvada, Srinivas
2017-08-08 9:15 ` Zhang Rui
0 siblings, 1 reply; 3+ messages in thread
From: Pandruvada, Srinivas @ 2017-07-29 19:22 UTC (permalink / raw)
To: Zhang, Rui, edubezval@gmail.com, arnd@arndb.de
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
> We get a Kconfig warning when selecting this without also enabling
> CONFIG_PCI:
>
> warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
> SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
> IOSF_MBI which has unmet direct dependencies (PCI)
>
> This adds a new depedency.
>
> Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
> APIs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/thermal/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index b5b5facb8747..ac2a53823576 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
>
> config INTEL_SOC_DTS_IOSF_CORE
> tristate
> - depends on X86
> + depends on X86 && PCI
> select IOSF_MBI
> help
> This is becoming a common feature for Intel SoCs to expose
> the additional
> @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
>
> config INTEL_SOC_DTS_THERMAL
> tristate "Intel SoCs DTS thermal driver"
> - depends on X86
> + depends on X86 && PCI
> select INTEL_SOC_DTS_IOSF_CORE
> select THERMAL_WRITABLE_TRIPS
> help
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies
2017-07-29 19:22 ` Pandruvada, Srinivas
@ 2017-08-08 9:15 ` Zhang Rui
0 siblings, 0 replies; 3+ messages in thread
From: Zhang Rui @ 2017-08-08 9:15 UTC (permalink / raw)
To: Pandruvada, Srinivas, edubezval@gmail.com, arnd@arndb.de
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote:
> On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
> >
> > We get a Kconfig warning when selecting this without also enabling
> > CONFIG_PCI:
> >
> > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
> > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
> > IOSF_MBI which has unmet direct dependencies (PCI)
> >
> > This adds a new depedency.
> >
> > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
> > APIs")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
Applied.
thanks,
rui
> >
>
> >
> > ---
> > drivers/thermal/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index b5b5facb8747..ac2a53823576 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
> >
> > config INTEL_SOC_DTS_IOSF_CORE
> > tristate
> > - depends on X86
> > + depends on X86 && PCI
> > select IOSF_MBI
> > help
> > This is becoming a common feature for Intel SoCs to
> > expose
> > the additional
> > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
> >
> > config INTEL_SOC_DTS_THERMAL
> > tristate "Intel SoCs DTS thermal driver"
> > - depends on X86
> > + depends on X86 && PCI
> > select INTEL_SOC_DTS_IOSF_CORE
> > select THERMAL_WRITABLE_TRIPS
> > help
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-08 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 16:16 [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies Arnd Bergmann
2017-07-29 19:22 ` Pandruvada, Srinivas
2017-08-08 9:15 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).