From: Joe Perches <joe@perches.com>
To: gaurav jindal <gauravjindal1104@gmail.com>,
rjw@rjwysocki.net, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
toddpoynor@google.com
Subject: Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
Date: Thu, 07 Sep 2017 03:33:26 -0700 [thread overview]
Message-ID: <1504780406.7546.19.camel@perches.com> (raw)
In-Reply-To: <20170907102325.GA6427@kernel>
On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote:
> This patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
If you are going to propose a checkpatch only patch,
please run your proposed patch through checkpatch.
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
[]
>
> @@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
> if (ret)
> return ret;
>
> - if (cpuidle_curr_governor->enable &&
> - (ret = cpuidle_curr_governor->enable(drv, dev)))
> - goto fail_sysfs;
> + if (cpuidle_curr_governor->enable) {
> +
> + ret = cpuidle_curr_governor->enable(drv, dev);
> + if (ret)
> + goto fail_sysfs;
> + }
checkpatch should complain here about unnecessary
blank line after open brace
next prev parent reply other threads:[~2017-09-07 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 10:23 [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal
2017-09-07 10:33 ` Joe Perches [this message]
2017-09-07 12:40 ` gaurav jindal
2017-09-07 23:18 ` Rafael J. Wysocki
2017-09-08 13:36 ` gaurav jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504780406.7546.19.camel@perches.com \
--to=joe@perches.com \
--cc=daniel.lezcano@linaro.org \
--cc=gauravjindal1104@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).