From: Leonard Crestez <leonard.crestez@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, Bai Ping <ping.bai@nxp.com>
Subject: Re: [PATCH] ARM: imx: Enable cpuidle for i.MX6DL starting at 1.1
Date: Tue, 10 Oct 2017 14:57:35 +0300 [thread overview]
Message-ID: <1507636655.20816.8.camel@nxp.com> (raw)
In-Reply-To: <1507635857.2745.12.camel@pengutronix.de>
On Tue, 2017-10-10 at 13:44 +0200, Lucas Stach wrote:
> Am Dienstag, den 10.10.2017, 14:20 +0300 schrieb Leonard Crestez:
> > Enable cpuidle support on i.MX6DL starting from
> > IMX_CHIP_REVISION_1_1.
> Did you mean 1.0 here and in the subject? This would make sense AFAICS,
> and is also in line with what the code change does.
No, I do mean "1.1" for 6dl. It's a bit confusing because the code uses
> instead of >= for comparison.
This patch results in imx6q_cpuidle_init getting called if
(cpu_is_imx6dl() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_1);
without this patch it was skipped.
> > --- a/arch/arm/mach-imx/mach-imx6q.c
> > +++ b/arch/arm/mach-imx/mach-imx6q.c
> > @@ -374,7 +374,8 @@ static void __init imx6q_init_late(void)
> > >
> > > * WAIT mode is broken on TO 1.0 and 1.1, so there is no point
> > > * to run cpuidle on them.
> > > */
> > > - if (imx_get_soc_revision() > IMX_CHIP_REVISION_1_1)
> > > + if ((cpu_is_imx6q() && imx_get_soc_revision() > IMX_CHIP_REVISION_1_1) ||
> > > + (cpu_is_imx6dl() && imx_get_soc_revision() > IMX_CHIP_REVISION_1_0))
> > > imx6q_cpuidle_init();
next prev parent reply other threads:[~2017-10-10 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 11:20 [PATCH] ARM: imx: Enable cpuidle for i.MX6DL starting at 1.1 Leonard Crestez
2017-10-10 11:44 ` Lucas Stach
2017-10-10 11:57 ` Leonard Crestez [this message]
2017-10-10 12:26 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507636655.20816.8.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).