From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: edubezval@gmail.com, rui.zhang@intel.com
Cc: linux-pm@vger.kernel.org, leo.yan@linaro.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 07/18] thermal/drivers/hisi: Encapsulate register writes into helpers
Date: Thu, 19 Oct 2017 19:05:49 +0200 [thread overview]
Message-ID: <1508432760-17847-7-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1508432760-17847-1-git-send-email-daniel.lezcano@linaro.org>
Hopefully, the function name can help to clarify the semantic of the operations
when writing in the register.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/hisi_thermal.c | 92 ++++++++++++++++++++++++++++++++----------
1 file changed, 70 insertions(+), 22 deletions(-)
diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index b657ae4..8e8a117 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -26,6 +26,7 @@
#include "thermal_core.h"
+#define TEMP0_LAG (0x0)
#define TEMP0_TH (0x4)
#define TEMP0_RST_TH (0x8)
#define TEMP0_CFG (0xC)
@@ -96,6 +97,56 @@ static inline long hisi_thermal_round_temp(int temp)
hisi_thermal_temp_to_step(temp));
}
+static inline void hisi_thermal_set_lag(void __iomem *addr, int value)
+{
+ writel(value, addr + TEMP0_LAG);
+}
+
+static inline void hisi_thermal_alarm_clear(void __iomem *addr, int value)
+{
+ writel(value, addr + TEMP0_INT_CLR);
+}
+
+static inline void hisi_thermal_alarm_enable(void __iomem *addr, int value)
+{
+ writel(value, addr + TEMP0_INT_EN);
+}
+
+static inline void hisi_thermal_alarm_set(void __iomem *addr, int temp)
+{
+ writel(hisi_thermal_temp_to_step(temp) | 0x0FFFFFF00, addr + TEMP0_TH);
+}
+
+static inline void hisi_thermal_reset_set(void __iomem *addr, int temp)
+{
+ writel(hisi_thermal_temp_to_step(temp), addr + TEMP0_RST_TH);
+}
+
+static inline void hisi_thermal_reset_enable(void __iomem *addr, int value)
+{
+ writel(value, addr + TEMP0_RST_MSK);
+}
+
+static inline void hisi_thermal_enable(void __iomem *addr, int value)
+{
+ writel(value, addr + TEMP0_EN);
+}
+
+static inline void hisi_thermal_sensor_select(void __iomem *addr, int sensor)
+{
+ writel((sensor << 12), addr + TEMP0_CFG);
+}
+
+static inline int hisi_thermal_get_temperature(void __iomem *addr)
+{
+ return hisi_thermal_step_to_temp(readl(addr + TEMP0_VALUE));
+}
+
+static inline void hisi_thermal_hdak_set(void __iomem *addr, int value)
+{
+ writel(value, addr + TEMP0_CFG);
+}
+
static long hisi_thermal_get_sensor_temp(struct hisi_thermal_data *data,
struct hisi_thermal_sensor *sensor)
{
@@ -104,22 +155,21 @@ static long hisi_thermal_get_sensor_temp(struct hisi_thermal_data *data,
mutex_lock(&data->thermal_lock);
/* disable interrupt */
- writel(0x0, data->regs + TEMP0_INT_EN);
- writel(0x1, data->regs + TEMP0_INT_CLR);
+ hisi_thermal_alarm_enable(data->regs, 0);
+ hisi_thermal_alarm_clear(data->regs, 1);
/* disable module firstly */
- writel(0x0, data->regs + TEMP0_EN);
+ hisi_thermal_enable(data->regs, 0);
/* select sensor id */
- writel((sensor->id << 12), data->regs + TEMP0_CFG);
+ hisi_thermal_sensor_select(data->regs, sensor->id);
/* enable module */
- writel(0x1, data->regs + TEMP0_EN);
+ hisi_thermal_enable(data->regs, 1);
usleep_range(3000, 5000);
- val = readl(data->regs + TEMP0_VALUE);
- val = hisi_thermal_step_to_temp(val);
+ val = hisi_thermal_get_temperature(data->regs);
mutex_unlock(&data->thermal_lock);
@@ -136,28 +186,26 @@ static void hisi_thermal_enable_bind_irq_sensor
sensor = &data->sensors;
/* setting the hdak time */
- writel(0x0, data->regs + TEMP0_CFG);
+ hisi_thermal_hdak_set(data->regs, 0);
/* disable module firstly */
- writel(0x0, data->regs + TEMP0_RST_MSK);
- writel(0x0, data->regs + TEMP0_EN);
+ hisi_thermal_reset_enable(data->regs, 0);
+ hisi_thermal_enable(data->regs, 0);
/* select sensor id */
- writel((sensor->id << 12), data->regs + TEMP0_CFG);
+ hisi_thermal_sensor_select(data->regs, sensor->id);
/* enable for interrupt */
- writel(hisi_thermal_temp_to_step(sensor->thres_temp) | 0x0FFFFFF00,
- data->regs + TEMP0_TH);
+ hisi_thermal_alarm_set(data->regs, sensor->thres_temp);
- writel(hisi_thermal_temp_to_step(HISI_TEMP_RESET),
- data->regs + TEMP0_RST_TH);
+ hisi_thermal_reset_set(data->regs, HISI_TEMP_RESET);
/* enable module */
- writel(0x1, data->regs + TEMP0_RST_MSK);
- writel(0x1, data->regs + TEMP0_EN);
+ hisi_thermal_reset_enable(data->regs, 1);
+ hisi_thermal_enable(data->regs, 1);
- writel(0x0, data->regs + TEMP0_INT_CLR);
- writel(0x1, data->regs + TEMP0_INT_EN);
+ hisi_thermal_alarm_clear(data->regs, 0);
+ hisi_thermal_alarm_enable(data->regs, 1);
usleep_range(3000, 5000);
@@ -169,9 +217,9 @@ static void hisi_thermal_disable_sensor(struct hisi_thermal_data *data)
mutex_lock(&data->thermal_lock);
/* disable sensor module */
- writel(0x0, data->regs + TEMP0_INT_EN);
- writel(0x0, data->regs + TEMP0_RST_MSK);
- writel(0x0, data->regs + TEMP0_EN);
+ hisi_thermal_enable(data->regs, 0);
+ hisi_thermal_alarm_enable(data->regs, 0);
+ hisi_thermal_reset_enable(data->regs, 0);
mutex_unlock(&data->thermal_lock);
}
--
2.7.4
next prev parent reply other threads:[~2017-10-19 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 17:05 [GIT PULL] thermal: new material for hikey for 4.15 #2 Daniel Lezcano
2017-10-19 17:05 ` [PATCH 01/18] thermal/drivers/hisi: Fix missing interrupt enablement Daniel Lezcano
2017-10-19 17:05 ` [PATCH 02/18] thermal/drivers/hisi: Remove the multiple sensors support Daniel Lezcano
2017-10-19 17:05 ` [PATCH 03/18] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Daniel Lezcano
2017-10-19 17:05 ` [PATCH 04/18] thermal/drivers/hisi: Simplify the temperature/step computation Daniel Lezcano
2017-10-19 17:05 ` [PATCH 05/18] thermal/drivers/hisi: Fix multiple alarm interrupts firing Daniel Lezcano
2017-10-19 17:05 ` [PATCH 06/18] thermal/drivers/hisi: Remove pointless lock Daniel Lezcano
2017-10-19 17:05 ` Daniel Lezcano [this message]
2017-10-19 17:05 ` [PATCH 08/18] thermal/drivers/hisi: Fix configuration register setting Daniel Lezcano
2017-10-19 17:05 ` [PATCH 09/18] thermal/drivers/hisi: Remove costly sensor inspection Daniel Lezcano
2017-10-19 17:05 ` [PATCH 10/18] thermal/drivers/hisi: Rename and remove unused field Daniel Lezcano
2017-10-19 17:05 ` [PATCH 11/18] thermal/drivers/hisi: Convert long to int Daniel Lezcano
2017-10-19 17:05 ` [PATCH 12/18] thermal/drivers/hisi: Remove thermal data back pointer Daniel Lezcano
2017-10-19 17:05 ` [PATCH 13/18] thermal/drivers/hisi: Remove mutex_lock in the code Daniel Lezcano
2017-10-19 17:05 ` [PATCH 14/18] thermal/drivers/hisi: Move the clk setup in the corresponding functions Daniel Lezcano
2017-10-19 17:05 ` [PATCH 15/18] thermal/drivers/hisi: Use round up step value Daniel Lezcano
2017-10-19 17:05 ` [PATCH 16/18] thermal/drivers/step_wise: Fix temperature regulation misbehavior Daniel Lezcano
2017-10-19 17:05 ` [PATCH 17/18] thermal/drivers/generic-iio-adc: Switch tz request to devm version Daniel Lezcano
2017-10-19 17:06 ` [PATCH 18/18] thermal/drivers/qcom-spmi: Use devm_iio_channel_get Daniel Lezcano
2017-10-20 1:52 ` [PATCH 01/18] thermal/drivers/hisi: Fix missing interrupt enablement Eduardo Valentin
2017-10-20 6:35 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508432760-17847-7-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).