linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Kevin Hilman <khilman@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-pm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 1/3] clk: renesas: mstp: Keep wakeup sources active during system suspend
Date: Thu,  9 Nov 2017 14:27:00 +0100	[thread overview]
Message-ID: <1510234022-29442-2-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1510234022-29442-1-git-send-email-geert+renesas@glider.be>

If a device is part of the CPG/MSTP Clock Domain and to be used as a
wakeup source, it must be kept active during system suspend.

Currently this is handled in device-specific drivers by explicitly
increasing the use count of the module clock when the device is
configured as a wakeup source.  However, the proper way to prevent the
device from being stopped is to inform this requirement to the genpd
core, by setting the GENPD_FLAG_ACTIVE_WAKEUP flag.

Note that this will only affect devices configured as wakeup sources.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Integrate "clk: renesas: mstp: Use GENPD_FLAG_ACTIVE_WAKEUP",
---
 drivers/clk/renesas/clk-mstp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c
index 500a9e4e03c48957..0b222197a4576fd7 100644
--- a/drivers/clk/renesas/clk-mstp.c
+++ b/drivers/clk/renesas/clk-mstp.c
@@ -344,7 +344,7 @@ void __init cpg_mstp_add_clk_domain(struct device_node *np)
 		return;
 
 	pd->name = np->name;
-	pd->flags = GENPD_FLAG_PM_CLK;
+	pd->flags = GENPD_FLAG_PM_CLK | GENPD_FLAG_ACTIVE_WAKEUP;
 	pd->attach_dev = cpg_mstp_attach_dev;
 	pd->detach_dev = cpg_mstp_detach_dev;
 	pm_genpd_init(pd, &pm_domain_always_on_gov, false);
-- 
2.7.4


  reply	other threads:[~2017-11-09 13:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 13:26 [PATCH v2 0/3] PM / Domain: renesas: Fix active wakeup behavior Geert Uytterhoeven
2017-11-09 13:27 ` Geert Uytterhoeven [this message]
2017-12-14 14:10   ` [PATCH v2 1/3] clk: renesas: mstp: Keep wakeup sources active during system suspend Ulf Hansson
2017-12-14 15:43     ` Geert Uytterhoeven
2017-11-09 13:27 ` [PATCH v2 2/3] clk: renesas: cpg-mssr: " Geert Uytterhoeven
2017-12-14 14:11   ` Ulf Hansson
2017-12-14 15:44     ` Geert Uytterhoeven
2017-11-09 13:27 ` [PATCH v2 3/3] soc: renesas: rcar-sysc: " Geert Uytterhoeven
2017-12-14 14:11   ` Ulf Hansson
2017-12-18 11:22     ` Geert Uytterhoeven
2017-12-20 10:23       ` Simon Horman
2017-12-20 10:28         ` Geert Uytterhoeven
2017-12-20 11:46           ` Simon Horman
2017-11-10  9:57 ` [PATCH v2 0/3] PM / Domain: renesas: Fix active wakeup behavior Ulf Hansson
2017-11-10 10:22   ` Geert Uytterhoeven
2017-11-10 12:49     ` Ulf Hansson
2017-11-10 13:22       ` Geert Uytterhoeven
2017-11-10 15:52         ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510234022-29442-2-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=khilman@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).