From: Leonard Crestez <leonard.crestez@nxp.com>
To: Bastian Stender <bst@pengutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Shawn Guo <shawnguo@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] cpufreq: imx6q/thermal: imx: move CPU cooling device from thermal to cpufreq
Date: Wed, 13 Dec 2017 15:41:01 +0200 [thread overview]
Message-ID: <1513172461.2879.14.camel@nxp.com> (raw)
In-Reply-To: <2436262.8Qovylrth1@aspire.rjw.lan>
On Wed, 2017-12-13 at 02:00 +0100, Rafael J. Wysocki wrote:
> On Thursday, November 16, 2017 12:49:18 PM CET Shawn Guo wrote:
> >
> > On Wed, Nov 15, 2017 at 10:23:32AM +0100, Bastian Stender wrote:
> > >
> > > The cooling device should be part of the i.MX cpufreq driver. So move
> > > it there.
> > >
> > > Use of_cpufreq_power_cooling_register to link the cooling device to the
> > > device tree node provided.
> > >
> > > This makes it possible to bind the cpufreq cooling device to a custom
> > > thermal zone via a cooling-maps entry like:
> > >
> > > cooling-maps {
> > > map0 {
> > > trip = <&board_alert>;
> > > cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > > };
> > > };
> > >
> > > Assuming a cpu node exists with label "cpu0" and #cooling-cells
> > > property.
> > >
> > > Signed-off-by: Bastian Stender <bst@pengutronix.de>
> > I'm fine with the patch, but I would invite Leonard to take a look.
> Given no response, what should I do?
Sorry for keeping you waiting. I don't much about the "cooling device"
infrastructure so I don't have much to add, I guess I assumed a reply
wasn't required?
Looking at the code you are removing "thermal_cooling_device *cdev;"
from imx_thermal_data but kept "cpufreq_policy *policy". Isn't that
unused now?
Also, your code only adds the cooling device if certain devicetree
properties are present. Shouldn't your patch come with imx6*.dtsi
changes, or make the capacitance value default to zero somehow?
Otherwise the effect of the patch on most boards would be to disable
cpufreq cooling.
--
Regards,
Leonard
next prev parent reply other threads:[~2017-12-13 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 9:23 [PATCH] cpufreq: imx6q/thermal: imx: move CPU cooling device from thermal to cpufreq Bastian Stender
2017-11-15 9:25 ` Viresh Kumar
2017-11-16 11:49 ` Shawn Guo
2017-12-13 1:00 ` Rafael J. Wysocki
2017-12-13 13:41 ` Leonard Crestez [this message]
2017-12-19 10:22 ` Bastian Stender
2017-12-19 10:30 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513172461.2879.14.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=bst@pengutronix.de \
--cc=edubezval@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).