From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Yan Subject: [PATCH] thermal: Use power efficient workqueue Date: Wed, 3 Jan 2018 17:24:16 +0800 Message-ID: <1514971456-2877-1-git-send-email-leo.yan@linaro.org> Return-path: Received: from mail-oi0-f67.google.com ([209.85.218.67]:34915 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbeACJYi (ORCPT ); Wed, 3 Jan 2018 04:24:38 -0500 Received: by mail-oi0-f67.google.com with SMTP id 184so603793oii.2 for ; Wed, 03 Jan 2018 01:24:38 -0800 (PST) Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , Daniel Lezcano , Vincent Guittot Thermal core framework uses the system_freezable_wq workqueue as its workqueue for polling temperature. Using system_freezable_wq workqueue prevents the scheduler to make smart decision about the best place to schedule the work. This commit replaces system_freezable_wq with system_freezable_power_efficient_wq. With kernel configuration CONFIG_WQ_POWER_EFFICIENT is enabled, the work can be scheduled on the best CPU from a power or a performance point of view. This commit is inspired by Vincent Guittot patch "netfilter: conntrack: use power efficient workqueue" and verified on 96boards Hikey960. Cc: Eduardo Valentin Cc: Zhang Rui Cc: Daniel Lezcano Cc: Vincent Guittot Signed-off-by: Leo Yan --- drivers/thermal/thermal_core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 2b1b0ba..ba90f71 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -293,11 +293,12 @@ static void thermal_zone_device_set_polling(struct thermal_zone_device *tz, int delay) { if (delay > 1000) - mod_delayed_work(system_freezable_wq, &tz->poll_queue, + mod_delayed_work(system_freezable_power_efficient_wq, + &tz->poll_queue, round_jiffies(msecs_to_jiffies(delay))); else if (delay) - mod_delayed_work(system_freezable_wq, &tz->poll_queue, - msecs_to_jiffies(delay)); + mod_delayed_work(system_freezable_power_efficient_wq, + &tz->poll_queue, msecs_to_jiffies(delay)); else cancel_delayed_work(&tz->poll_queue); } -- 2.7.4