* [PATCH] tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
@ 2018-01-05 22:31 Doug Smythies
2018-01-05 22:54 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Doug Smythies @ 2018-01-05 22:31 UTC (permalink / raw)
To: srinivas.pandruvada; +Cc: dsmythies, rjw, linux-kernel, linux-pm
The trace buffer memory should be, mostly, freed after
the buffer has been output.
This patch is required before a future patch that will allow
the user to override the default, and specify the trace buffer
memory allocation as a command line option.
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
.../power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
index 0b24dd9..29f50d4 100755
--- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
+++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
@@ -411,6 +411,16 @@ def set_trace_buffer_size():
print('IO error setting trace buffer size ')
quit()
+def free_trace_buffer():
+ """ Free the trace buffer memory """
+
+ try:
+ open('/sys/kernel/debug/tracing/buffer_size_kb'
+ , 'w').write("1")
+ except:
+ print('IO error setting trace buffer size ')
+ quit()
+
def read_trace_data(filename):
""" Read and parse trace data """
@@ -583,4 +593,9 @@ for root, dirs, files in os.walk('.'):
for f in files:
fix_ownership(f)
+clear_trace_file()
+# Free the memory
+if interval:
+ free_trace_buffer()
+
os.chdir('../../')
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
2018-01-05 22:31 [PATCH] tools/power/x86/intel_pstate_tracer: Free the trace buffer memory Doug Smythies
@ 2018-01-05 22:54 ` Rafael J. Wysocki
2018-01-05 23:46 ` Srinivas Pandruvada
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-01-05 22:54 UTC (permalink / raw)
To: Doug Smythies, Srinivas Pandruvada
Cc: Doug Smythies, Rafael J. Wysocki, Linux Kernel Mailing List,
Linux PM
On Fri, Jan 5, 2018 at 11:31 PM, Doug Smythies <doug.smythies@gmail.com> wrote:
> The trace buffer memory should be, mostly, freed after
> the buffer has been output.
>
> This patch is required before a future patch that will allow
> the user to override the default, and specify the trace buffer
> memory allocation as a command line option.
>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
Looks OK to me. Srinivas?
> ---
> .../power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> index 0b24dd9..29f50d4 100755
> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> @@ -411,6 +411,16 @@ def set_trace_buffer_size():
> print('IO error setting trace buffer size ')
> quit()
>
> +def free_trace_buffer():
> + """ Free the trace buffer memory """
> +
> + try:
> + open('/sys/kernel/debug/tracing/buffer_size_kb'
> + , 'w').write("1")
> + except:
> + print('IO error setting trace buffer size ')
> + quit()
> +
> def read_trace_data(filename):
> """ Read and parse trace data """
>
> @@ -583,4 +593,9 @@ for root, dirs, files in os.walk('.'):
> for f in files:
> fix_ownership(f)
>
> +clear_trace_file()
> +# Free the memory
> +if interval:
> + free_trace_buffer()
> +
> os.chdir('../../')
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
2018-01-05 22:54 ` Rafael J. Wysocki
@ 2018-01-05 23:46 ` Srinivas Pandruvada
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2018-01-05 23:46 UTC (permalink / raw)
To: Rafael J. Wysocki, Doug Smythies
Cc: Doug Smythies, Rafael J. Wysocki, Linux Kernel Mailing List,
Linux PM
On Fri, 2018-01-05 at 23:54 +0100, Rafael J. Wysocki wrote:
> On Fri, Jan 5, 2018 at 11:31 PM, Doug Smythies <doug.smythies@gmail.c
> om> wrote:
> >
> > The trace buffer memory should be, mostly, freed after
> > the buffer has been output.
> >
> > This patch is required before a future patch that will allow
> > the user to override the default, and specify the trace buffer
> > memory allocation as a command line option.
> >
> > Signed-off-by: Doug Smythies <dsmythies@telus.net>
> Looks OK to me. Srinivas?
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> >
> > ---
> > .../power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 15
> > +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git
> > a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > index 0b24dd9..29f50d4 100755
> > --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > @@ -411,6 +411,16 @@ def set_trace_buffer_size():
> > print('IO error setting trace buffer size ')
> > quit()
> >
> > +def free_trace_buffer():
> > + """ Free the trace buffer memory """
> > +
> > + try:
> > + open('/sys/kernel/debug/tracing/buffer_size_kb'
> > + , 'w').write("1")
> > + except:
> > + print('IO error setting trace buffer size ')
> > + quit()
> > +
> > def read_trace_data(filename):
> > """ Read and parse trace data """
> >
> > @@ -583,4 +593,9 @@ for root, dirs, files in os.walk('.'):
> > for f in files:
> > fix_ownership(f)
> >
> > +clear_trace_file()
> > +# Free the memory
> > +if interval:
> > + free_trace_buffer()
> > +
> > os.chdir('../../')
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-05 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-05 22:31 [PATCH] tools/power/x86/intel_pstate_tracer: Free the trace buffer memory Doug Smythies
2018-01-05 22:54 ` Rafael J. Wysocki
2018-01-05 23:46 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).