From: Anshuman Gupta <anshuman.gupta@intel.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, anshuman.gupta@intel.com
Subject: [PATCH] [sound] hdac-codec runtime suspended at PM:Suspend.
Date: Mon, 12 Mar 2018 16:47:47 +0530 [thread overview]
Message-ID: <1520853467-31653-1-git-send-email-anshuman.gupta@intel.com> (raw)
Keep hdac-codec to be in runtime suspended while entering to suspend.
If hdac-codec is already in runtime suspend state skip its power down
sequence in prepare, power up sequence in complete phase.
Avoid resuming hdac controller PCI device 00:1f.3 from runtime suspend
state in case hdac-codec already in runtime-suspend state, this is
unnecessary and block the direct complete even for hdac controller
PCI device 00:1f.3.
This enabled direct complete path for hdac-codec and PCI device 00:1f.3.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
sound/soc/codecs/hdac_hdmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
index f3b4f4d..810a8a6 100644
--- a/sound/soc/codecs/hdac_hdmi.c
+++ b/sound/soc/codecs/hdac_hdmi.c
@@ -1852,6 +1852,8 @@ static int hdmi_codec_prepare(struct device *dev)
struct hdac_ext_device *edev = to_hda_ext_device(dev);
struct hdac_device *hdac = &edev->hdac;
+ if (pm_runtime_status_suspended(dev))
+ return 1;
pm_runtime_get_sync(&edev->hdac.dev);
/*
@@ -1873,6 +1875,8 @@ static void hdmi_codec_complete(struct device *dev)
struct hdac_hdmi_priv *hdmi = edev->private_data;
struct hdac_device *hdac = &edev->hdac;
+ if (pm_runtime_status_suspended(dev))
+ return;
/* Power up afg */
snd_hdac_codec_read(hdac, hdac->afg, 0, AC_VERB_SET_POWER_STATE,
AC_PWRST_D0);
--
2.7.4
next reply other threads:[~2018-03-12 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 11:17 Anshuman Gupta [this message]
2018-03-12 11:26 ` [PATCH] [sound] hdac-codec runtime suspended at PM:Suspend Rafael J. Wysocki
2018-03-14 10:38 ` Anshuman Gupta
[not found] ` <5aa8fbe9.4251620a.c3daa.3711SMTPIN_ADDED_BROKEN@mx.google.com>
2018-03-14 10:53 ` Rafael J. Wysocki
2018-03-14 15:37 ` Anshuman Gupta
[not found] ` <20180314153714.GA11459@anshuman.gupta@intel.com>
2018-03-15 10:42 ` Subhransu S. Prusty
2018-03-15 15:32 ` Anshuman Gupta
[not found] ` <20180315153230.GA16531@anshuman.gupta@intel.com>
2018-03-26 7:03 ` Subhransu S. Prusty
2018-03-26 7:30 ` Takashi Iwai
2018-03-27 15:36 ` Lukas Wunner
2018-08-18 18:12 ` [PATCH v2 0/1] cover-letter " Anshuman Gupta
2018-08-18 18:12 ` [PATCH v2 1/1] " Anshuman Gupta
2018-08-28 16:34 ` Anshuman Gupta
2018-08-28 17:05 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520853467-31653-1-git-send-email-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).