From: Rik van Riel <riel@surriel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Thomas Ilsche <thomas.ilsche@tu-dresden.de>,
Doug Smythies <dsmythies@telus.net>,
Aubrey Li <aubrey.li@linux.intel.com>,
Mike Galbraith <mgalbraith@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] cpuidle: poll_state: Add time limit to poll_idle()
Date: Mon, 26 Mar 2018 17:48:22 -0400 [thread overview]
Message-ID: <1522100902.6308.60.camel@surriel.com> (raw)
In-Reply-To: <CAJZ5v0itoXKB+46w+yb1N5zyYF4bNsZ-1dgm2KqF2oDM426M6w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
On Mon, 2018-03-26 at 23:44 +0200, Rafael J. Wysocki wrote:
> On Mon, Mar 26, 2018 at 6:32 PM, Rik van Riel <riel@surriel.com>
> wrote:
> > On Sun, 2018-03-25 at 23:34 +0200, Rafael J. Wysocki wrote:
> >
> > I tried that, as well, and some other variations.
> >
> > Every single change to poll_idle() that I tried
> > seems to result in a 9-10% relative increase in
> > CPU use during the peak load of the test.
> >
> > During the busiest parts of the load, every CPU
> > sees on the order of 20k context switches a second.
... and I did something wrong in the tests :/
> Hmm. Basically, you are saying that
>
> while (something)
> cpu_relax();
>
> is measurably less overhead than
>
> while (something) {
> cpu_relax();
> check something else;
> cpu_relax();
> }
>
> which honestly makes me wonder how this is possible at all.
Part of the mystery is solved. Apparently the
control kernel was not the one I thought it
was, or the one that was printed in the
output messages :(
I am re-running the tests now with a few
variations, and seeing what works best.
My apologies for wasting everybody's time.
I should have valid results later tonight.
Fingers crossed.
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-26 21:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 14:08 [PATCH v3] cpuidle: poll_state: Add time limit to poll_idle() Rafael J. Wysocki
2018-03-22 16:32 ` Rik van Riel
2018-03-22 17:09 ` Rafael J. Wysocki
2018-03-22 17:19 ` Rik van Riel
2018-03-22 17:24 ` Rafael J. Wysocki
2018-03-25 20:15 ` Rik van Riel
2018-03-25 21:34 ` Rafael J. Wysocki
2018-03-25 21:45 ` Rik van Riel
2018-03-26 5:59 ` Doug Smythies
2018-03-26 7:13 ` Doug Smythies
2018-03-26 9:35 ` Rafael J. Wysocki
2018-03-26 16:32 ` Rik van Riel
2018-03-26 21:44 ` Rafael J. Wysocki
2018-03-26 21:48 ` Rik van Riel [this message]
2018-03-27 17:59 ` Rik van Riel
2018-03-27 21:06 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2018-03-14 15:00 Doug Smythies
2018-03-20 10:52 ` Rafael J. Wysocki
2018-03-25 0:28 Doug Smythies
2018-03-25 11:53 ` Rafael J. Wysocki
2018-03-25 21:41 ` Rafael J. Wysocki
2018-03-26 6:01 ` Doug Smythies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522100902.6308.60.camel@surriel.com \
--to=riel@surriel.com \
--cc=aubrey.li@linux.intel.com \
--cc=dsmythies@telus.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgalbraith@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=thomas.ilsche@tu-dresden.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).