From: Lucas Stach <l.stach@pengutronix.de>
To: Leonard Crestez <leonard.crestez@nxp.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de
Subject: Re: [PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287
Date: Wed, 11 Jul 2018 14:29:46 +0200 [thread overview]
Message-ID: <1531312186.3163.52.camel@pengutronix.de> (raw)
In-Reply-To: <1cc67fd7d1214f93f7ace6f0c2a46303f79a828e.camel@nxp.com>
Am Mittwoch, den 11.07.2018, 15:21 +0300 schrieb Leonard Crestez:
> On Wed, 2018-07-11 at 14:16 +0200, Lucas Stach wrote:
> > Am Mittwoch, den 11.07.2018, 15:11 +0300 schrieb Leonard Crestez:
> > > Handle this in the safest possible way by keeping the DISP domain
> > > always-on.
> > >
> > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> >
> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> >
> > Can you send a follow on patch to switch the i.MX6QP errata
> > workaround
> > to use GENPD_FLAG_ALWAYS_ON and remove the -EBUSY stuff in the
> > power
> > down path?
>
> Sure.
>
> I was thinking of converting it to a new GENPD_FLAG which allows
> power_off in suspend (as suggested by Ulf) but switching to
> GENPD_FLAG_ALWAYS_ON in order to simplify the code could be done
> first.
Sure, if you are going to work on this I'm fine with converting it over
to this without first going for GENPD_FLAG_ALWAYS_ON. Just wanted to
make sure that things are consistent.
> The -EBUSY stuff is not very harmful.
It's dead code once the appropriate flags have been added to the
domain, so should be removed.
Regards,
Lucas
next prev parent reply other threads:[~2018-07-11 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 12:11 [PATCH v3 0/2] Fix imx6sl display power domain Leonard Crestez
2018-07-11 12:11 ` [PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287 Leonard Crestez
2018-07-11 12:16 ` Lucas Stach
2018-07-11 12:21 ` Leonard Crestez
2018-07-11 12:29 ` Lucas Stach [this message]
2018-07-11 12:19 ` Ulf Hansson
2018-07-11 12:11 ` [PATCH v3 2/2] ARM: dts: imx6sl: Convert gpc to new bindings Leonard Crestez
2018-07-11 12:17 ` Lucas Stach
2018-07-11 13:20 ` [PATCH v3 0/2] Fix imx6sl display power domain Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531312186.3163.52.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).