Re: [PATCH] PM: wakup: export wakeup irq when system aborts suspend

[Zhang Rui <rui.zhang@intel.com>]

On 三, 2019-04-24 at 09:29 +0200, Rafael J. Wysocki wrote:
> On Wed, Apr 24, 2019 at 8:59 AM Zhang Rui <rui.zhang@intel.com>
> wrote:
> > 
> > 
> > When suspend is aborted because of an ARMED irq, we can not get any
> > useful information about which irq is triggered.
> That should be provided via the /sys/power/pm_wakeup_irq attribute.
> 
another case is that,
say we got spurious wakeup interrupts in the idle loop, and then waked
by a real wakeup interrupt, say, rtc.
/sys/power/pm_wakeup_irq only shows the latest one, and we can not find
out the spurious wakeup interrupts.

I should add this in the changelog as well.

thanks,
rui

> > 
> > Export the wakeup irq via suspend_resume trace event in this case.
> > 
> > Signed-off-by: Brandt, Todd E <todd.e.brandt@intel.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> >  drivers/base/power/wakeup.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/base/power/wakeup.c
> > b/drivers/base/power/wakeup.c
> > index bb1ae17..d32bd91 100644
> > --- a/drivers/base/power/wakeup.c
> > +++ b/drivers/base/power/wakeup.c
> > @@ -875,6 +875,7 @@ void pm_system_irq_wakeup(unsigned int
> > irq_number)
> >  {
> >         if (pm_wakeup_irq == 0) {
> >                 pm_wakeup_irq = irq_number;
> > +               trace_suspend_resume(TPS("irq_wakeup"), irq_number,
> > true);
> pm_wakeup_irq can be read from /sys/power/pm_wakeup_irq, so why is it
> necessary to trace it additionally?
> 
> > 
> >                 pm_system_wakeup();
> >         }
> >  }
> > --