From: Zhang Rui <rui.zhang@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Subject: Re: [PATCH V2 00/13] intel_rapl: RAPL abstraction and MMIO RAPL support
Date: Mon, 08 Jul 2019 14:53:35 +0800 [thread overview]
Message-ID: <1562568815.2810.18.camel@intel.com> (raw)
In-Reply-To: <CAJZ5v0ixFF-_5yYZhWBJLUaE6oreaGY1BELGTsYfqYw3M9sDcQ@mail.gmail.com>
On 六, 2019-07-06 at 10:19 +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 5, 2019 at 4:59 PM Pandruvada, Srinivas
> <srinivas.pandruvada@intel.com> wrote:
> >
> >
> > On Fri, 2019-07-05 at 10:57 +0200, Rafael J. Wysocki wrote:
> > >
> > > On Thu, Jul 4, 2019 at 6:34 PM Zhang Rui <rui.zhang@intel.com>
> > > wrote:
> > > >
> > > >
> > > > Besideis MSR interface, RAPL can also be controlled via the
> > > > MMIO
> > > > interface,
> > > > by accessing the MCHBar registers exposed by the processor
> > > > thermal
> > > > device.
> > > >
> > > > Currently, we only have RAPL MSR interface in Linux kernel,
> > > > this
> > > > brings
> > > > problems on some platforms that BIOS performs a low power
> > > > limits
> > > > via the
> > > > MMIO interface by default. This results in poor system
> > > > performance,
> > > > and there is no way for us to change the MMIO MSR setting in
> > > > Linux.
> > > >
> > > > To fix this, RAPL MMIO interface support is introduced in this
> > > > patch set.
> > > >
> > > > Patch 1/13 to patch 11/13 abstract the RAPL code, and move all
> > > > the
> > > > shared
> > > > code into a separate file, intel_rapl_common.c, so that it can
> > > > be
> > > > used
> > > > by both MSR and MMIO interfaces.
> > > > Patch 12/13 introduced RAPL support via MMIO registers, exposed
> > > > by
> > > > the
> > > > processor thermal devices.
> > > > Patch 13/13 fixes a module autoloading issue found later.
> > > >
> > > > The patch series has been tested on Dell XPS 9360, a SKL
> > > > platform.
> > > >
> > > > Note that this patch series are based on the -tip tree, which
> > > > contains the
> > > > latest RAPL changes for multi-die support.
> > > >
> > > > Changes in V2:
> > > > - add kerneldoc for struct rapl_if_priv.
> > > > - use intel_rapl_msr.c for RAPL MSR I/F driver, instead of
> > > > intel_rapl.c.
> > > > - changelog and coding style update.
> > > What tree is the series against?
> > >
> > > It doesn't apply either on top of my powercap branch or on top of
> > > 5.2-rc7 for me.
> > This needs linux tip tree. There are some package/die changes in
> > tip
> > tree, which this patch depends on.
> OK, so the changes in -tip need to go in first.
>
exactly.
BTW, this patch set also conflicts with the RAPL support patches for
icelake platforms. Thus IMO, having a separate rapl branch, and apply
the icl rapl patches on top of this patch set will be much easier.
thanks,
rui
next prev parent reply other threads:[~2019-07-08 6:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 16:34 [PATCH V2 00/13] intel_rapl: RAPL abstraction and MMIO RAPL support Zhang Rui
2019-07-04 16:34 ` [PATCH V2 01/13] intel_rapl: use reg instead of msr Zhang Rui
2019-07-04 16:34 ` [PATCH V2 02/13] intel_rapl: remove hardcoded register index Zhang Rui
2019-07-04 16:34 ` [PATCH V2 03/13] intel_rapl: introduce intel_rapl.h Zhang Rui
2019-07-04 16:34 ` [PATCH V2 04/13] intel_rapl: introduce struct rapl_if_private Zhang Rui
2019-07-04 16:34 ` [PATCH V2 05/13] intel_rapl: abstract register address Zhang Rui
2019-07-04 16:34 ` [PATCH V2 06/13] intel_rapl: abstract register access operations Zhang Rui
2019-07-04 16:34 ` [PATCH V2 07/13] intel_rapl: cleanup some functions Zhang Rui
2019-07-04 16:34 ` [PATCH V2 08/13] intel_rapl: cleanup hardcoded MSR access Zhang Rui
2019-07-04 16:34 ` [PATCH V2 09/13] intel_rapl: abstract RAPL common code Zhang Rui
2019-07-04 16:34 ` [PATCH V2 10/13] intel_rapl: support 64 bit register Zhang Rui
2019-07-04 16:34 ` [PATCH V2 11/13] intel_rapl: support two power limits for every RAPL domain Zhang Rui
2019-07-04 16:34 ` [PATCH V2 12/13] int340X/processor_thermal_device: add support for MMIO RAPL Zhang Rui
2019-07-04 16:34 ` [PATCH V2 13/13] intel_rapl: Fix module autoloading issue Zhang Rui
2019-07-05 8:57 ` [PATCH V2 00/13] intel_rapl: RAPL abstraction and MMIO RAPL support Rafael J. Wysocki
2019-07-05 14:59 ` Pandruvada, Srinivas
2019-07-06 8:19 ` Rafael J. Wysocki
2019-07-08 6:53 ` Zhang Rui [this message]
2019-07-08 8:58 ` Rafael J. Wysocki
2019-07-09 13:41 ` Zhang Rui
2019-07-09 13:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562568815.2810.18.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).