Re: [PATCH V2 08/11] opp: Add OPP sharing information to OPP library

Bartlomiej Zolnierkiewicz
2015-07-27T14:49:36Z

Hi,

Two very minor nits:

On Monday, July 27, 2015 10:32:38 AM Viresh Kumar wrote:
> An opp can be shared by multiple devices, for example its very common
> for CPUs to share the OPPs, i.e. when they share clock/voltage rails.
>
> This patch adds support of shared OPPs to the OPP library.
>
> Instead of a single device, dev_opp will not contain a list of devices

s/will not/will now/ ?

> that use it. It also senses if the device (we are trying to initialize
> OPPs for) shares OPPs with a device added earlier and in that case we
> update the list of devices managed by OPPs instead of duplicating OPPs
> again.
>
> The same infrastructure will be used for the old OPP bindings, with
> later patches.
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

[...]

> +static struct device_list_opp *_add_list_dev(const struct device *dev,
> + struct device_opp *dev_opp)
> +{
> + struct device_list_opp *list_dev;
> +
> + list_dev = kzalloc(sizeof(*list_dev), GFP_KERNEL);
> + if (!list_dev)
> + return NULL;
> +
> + /* Initialize list-dev */
> + list_add_rcu(&list_dev->node, &dev_opp->dev_list);
> + list_dev->dev = dev;

Probably doesn't matter currently but how's about:

list_dev->dev = dev;
list_add_rcu(&list_dev->node, &dev_opp->dev_list);

?

> +
> + return list_dev;
> +}

Otherwise:

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics