From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Abraham <thomas.ab@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kevin Hilman <khilman@linaro.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Anand Moon <linux.amoon@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] cpufreq-dt: add turbo modes support
Date: Mon, 27 Jul 2015 13:01:43 +0200 [thread overview]
Message-ID: <15810554.2OjPyuYJBt@amdc1976> (raw)
In-Reply-To: <20150727083754.GD31611@linux>
Hi,
On Monday, July 27, 2015 02:07:54 PM Viresh Kumar wrote:
> On 09-07-15, 17:43, Bartlomiej Zolnierkiewicz wrote:
> > diff --git a/include/linux/cpufreq-dt.h b/include/linux/cpufreq-dt.h
> > index 0414009..483ca1b 100644
> > --- a/include/linux/cpufreq-dt.h
> > +++ b/include/linux/cpufreq-dt.h
> > @@ -17,6 +17,7 @@ struct cpufreq_dt_platform_data {
> > * clock.
> > */
> > bool independent_clocks;
> > + bool boost_supported;
> > };
>
> I am planning to kill this structure soon, don't add anything to it.
> We should be doing this based on DT.
This change was in the original patch posted in April:
https://lkml.org/lkml/2015/4/10/646
your review from a month ago didn't contain this request:
https://lkml.org/lkml/2015/6/22/667
and now (after nearly 4 months) you are telling me that
I should change this because you are planning to do some
more changes in the future.
Could we please keep it as it is for now and change it
later (after independent_clocks configuration will get
ported to use device tree)?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2015-07-27 11:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 15:43 [PATCH v2 0/7] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz
2015-07-09 15:43 ` [PATCH v2 1/7] opp: add dev_pm_opp_get_turbo_mode_setting() helper Bartlomiej Zolnierkiewicz
2015-07-10 2:17 ` Krzysztof Kozlowski
2015-07-27 8:33 ` Viresh Kumar
2015-07-09 15:43 ` [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Bartlomiej Zolnierkiewicz
2015-07-10 2:20 ` Krzysztof Kozlowski
2015-07-27 8:35 ` Viresh Kumar
2015-07-27 10:24 ` Bartlomiej Zolnierkiewicz
2015-07-27 10:35 ` Viresh Kumar
2015-07-27 11:14 ` Bartlomiej Zolnierkiewicz
2015-07-27 11:36 ` Viresh Kumar
2015-07-27 11:47 ` Bartlomiej Zolnierkiewicz
2015-07-30 14:37 ` Kukjin Kim
2015-07-31 18:58 ` Bartlomiej Zolnierkiewicz
2015-08-04 1:31 ` Krzysztof Kozlowski
2015-07-09 15:43 ` [PATCH v2 3/7] cpufreq-dt: add turbo modes support Bartlomiej Zolnierkiewicz
2015-07-10 8:22 ` Krzysztof Kozlowski
2015-07-27 8:37 ` Viresh Kumar
2015-07-27 11:01 ` Bartlomiej Zolnierkiewicz [this message]
2015-07-27 11:33 ` Viresh Kumar
2015-07-27 11:58 ` Bartlomiej Zolnierkiewicz
2015-07-27 12:01 ` Viresh Kumar
2015-07-09 15:43 ` [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock Bartlomiej Zolnierkiewicz
2015-07-10 8:30 ` Krzysztof Kozlowski
2015-07-10 16:12 ` Javier Martinez Canillas
2015-07-11 6:36 ` Krzysztof Kozlowski
2015-07-15 9:58 ` Sylwester nawrocki
2015-07-09 15:43 ` [PATCH v2 5/7] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property Bartlomiej Zolnierkiewicz
2015-07-10 8:35 ` Krzysztof Kozlowski
2015-07-09 15:43 ` [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Bartlomiej Zolnierkiewicz
2015-07-10 8:55 ` Krzysztof Kozlowski
2015-07-09 15:43 ` [PATCH v2 7/7] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support Bartlomiej Zolnierkiewicz
2015-07-10 8:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15810554.2OjPyuYJBt@amdc1976 \
--to=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=heiko@sntech.de \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@linaro.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tomasz.figa@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).