From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Lan Tianyu <tianyu.lan@intel.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] Cpufreq: Make governor data on nonboot cpus across system suspend/resume
Date: Thu, 21 Nov 2013 22:43:45 +0100 [thread overview]
Message-ID: <1599716.5y7kNnD1dc@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohponphVhZ3T1HD2AfhPBUn9SfQyrqdbvW3bEJFzRdKF2i0Q@mail.gmail.com>
On Thursday, November 21, 2013 09:24:02 PM Viresh Kumar wrote:
> On 21 November 2013 20:13, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >> - if (((event == CPUFREQ_GOV_POLICY_INIT) && ret) ||
> >
> > The inner parens are not necessary.
> >
> >> - ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret))
> >> + if ((event == CPUFREQ_GOV_POLICY_INIT) && ret) {
> >
> > Same here.
> >
> >> + module_put(policy->governor->owner);
> >> + if (ret == -EALREADY)
> >> + return 0;
> >> + } else if ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret) {
> >
> > Same here.
>
> Logically, yes you are correct. But probably its better for readability to
> get these even if you know precedence is going to take care of our
> expression..
Are you serious?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-11-21 21:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 6:01 [PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system syspend/resume Lan Tianyu
2013-11-15 8:15 ` [Update PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system suspend/resume Lan Tianyu
2013-11-15 10:22 ` Viresh Kumar
2013-11-16 4:33 ` Lan Tianyu
2013-11-15 10:54 ` Viresh Kumar
2013-11-16 5:24 ` viresh kumar
2013-11-16 0:38 ` Rafael J. Wysocki
2013-11-16 3:59 ` Lan Tianyu
2013-11-16 14:41 ` Rafael J. Wysocki
2013-11-16 14:57 ` Viresh Kumar
2013-11-16 15:10 ` Rafael J. Wysocki
2013-11-16 15:09 ` Rafael J. Wysocki
2013-11-16 15:23 ` Lan Tianyu
2013-11-16 15:36 ` [PATCH V2] " Lan Tianyu
2013-11-17 4:13 ` viresh kumar
2013-11-17 14:44 ` Rafael J. Wysocki
2013-11-17 16:23 ` Viresh Kumar
2013-11-22 7:49 ` viresh kumar
2013-11-22 8:19 ` Lan Tianyu
2013-11-22 8:39 ` Viresh Kumar
2013-11-21 14:43 ` Rafael J. Wysocki
2013-11-21 15:54 ` Viresh Kumar
2013-11-21 21:43 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599716.5y7kNnD1dc@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=tianyu.lan@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox