Re: [PATCH v6 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for I/O devices

Geert Uytterhoeven
2016-04-22T07:59:58Z

Hi Ulf,

On Fri, Apr 22, 2016 at 9:28 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> @@ -217,6 +218,8 @@ static int rcar_sysc_pd_power_on(struct generic_pm_domain *genpd)
>> return rcar_sysc_power_up(&pd->ch);
>> }
>>
>> +static bool has_cpg_mstp;
>> +
>
> That's seems lazy. :-)
>
> Sure you can provide this as an input parameter to
> rcar_sysc_pd_setup() instead, no?

This variable is intended to go away, once all R-Car SoCs have been converted
to use the CPG/MSSR driver, and has_cpg_mstp will always be false.
Then we can just remove those lines, instead of reworking the parameter
passing.

(I have to admit I just didn't think about using a parameter, but the
explanation above is still valid)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds