linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH V3] PM / EM: Micro optimization in em_cpu_energy
       [not found] <671427cc-2abb-68eb-5e54-0851785efa84@intel.com>
@ 2020-11-28  1:39 ` Pavankumar Kondeti
  2020-12-08 17:24   ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Pavankumar Kondeti @ 2020-11-28  1:39 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-pm, Dietmar Eggemann, Pavankumar Kondeti, Lukasz Luba,
	Rafael J. Wysocki, Daniel Lezcano, Quentin Perret,
	Gustavo A. R. Silva

When the sum of the utilization of CPUs in a power domain is zero,
return the energy as 0 without doing any computations.

Acked-by: Quentin Perret <qperret@google.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
---
 include/linux/energy_model.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
index b67a51c..8810f1f 100644
--- a/include/linux/energy_model.h
+++ b/include/linux/energy_model.h
@@ -103,6 +103,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
 	struct em_perf_state *ps;
 	int i, cpu;
 
+	if (!sum_util)
+		return 0;
+
 	/*
 	 * In order to predict the performance state, map the utilization of
 	 * the most utilized CPU of the performance domain to a requested
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RESEND PATCH V3] PM / EM: Micro optimization in em_cpu_energy
  2020-11-28  1:39 ` [RESEND PATCH V3] PM / EM: Micro optimization in em_cpu_energy Pavankumar Kondeti
@ 2020-12-08 17:24   ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-12-08 17:24 UTC (permalink / raw)
  To: Pavankumar Kondeti
  Cc: Linux Kernel Mailing List, Linux PM, Dietmar Eggemann,
	Lukasz Luba, Rafael J. Wysocki, Daniel Lezcano, Quentin Perret,
	Gustavo A. R. Silva

On Sat, Nov 28, 2020 at 3:21 AM Pavankumar Kondeti
<pkondeti@codeaurora.org> wrote:
>
> When the sum of the utilization of CPUs in a power domain is zero,
> return the energy as 0 without doing any computations.
>
> Acked-by: Quentin Perret <qperret@google.com>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> ---
>  include/linux/energy_model.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> index b67a51c..8810f1f 100644
> --- a/include/linux/energy_model.h
> +++ b/include/linux/energy_model.h
> @@ -103,6 +103,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
>         struct em_perf_state *ps;
>         int i, cpu;
>
> +       if (!sum_util)
> +               return 0;
> +
>         /*
>          * In order to predict the performance state, map the utilization of
>          * the most utilized CPU of the performance domain to a requested
> --

Applied as 5.11 material, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-08 17:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <671427cc-2abb-68eb-5e54-0851785efa84@intel.com>
2020-11-28  1:39 ` [RESEND PATCH V3] PM / EM: Micro optimization in em_cpu_energy Pavankumar Kondeti
2020-12-08 17:24   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).