From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05E8813F43B for ; Thu, 21 Nov 2024 17:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732208578; cv=none; b=h/Za/NCCENEg85eiU3p5QeSDuXNES8DbqE+rpF6euWtGD9GHrcrxJSj/0REsZcAw1E38YQqnW/MBO680WIzFovoGaQYJkWROq1Vtfqw04+hr9PMdXdReastdRkto/F/Gt/JnroYxixSgdvJnHb3cEGF07VyZUT1gj3879+Xugrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732208578; c=relaxed/simple; bh=6Vxlo6faN0C7NKlDfybU/omsUYxPPrRyafoIvqDiFYM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ryCOSC4fXGtNfbiLNftPEnaEYaOEMDrQjDeUmnIAXxEsXSE4u4fpCOjpn+p5Qp3POc+CVt2YYIiv/jVXWC87LZz3O6NEliY5KLus2Qhbq6vEAwh6CWsJjw5z2fSru6Y10VKx92rmcljo9oRSHxLwACGdkZsDat9pEHAWKF8kXJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=LW+7PAa7; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LW+7PAa7" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6cd7a2ed34bso7257276d6.2 for ; Thu, 21 Nov 2024 09:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1732208575; x=1732813375; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dm8PbpGiosnEoyCAfA49zTMv9AsgSpHySYaBHhyFgZc=; b=LW+7PAa7GXR6xaxdOiU17MJ6R8RbR0+O8a2Sw1OWYgACvC+F6uXiLScH/Rt9DobAWd 3mPzDiEYoHEvMlodELDco/h3RstZAL0mBP4iPtQaZltdcskLauXjWdAL18dqOxVIuxvp gam2a1M+LZX34clCKIhOmF42uY1K5wmtYwySc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732208575; x=1732813375; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dm8PbpGiosnEoyCAfA49zTMv9AsgSpHySYaBHhyFgZc=; b=JKZeYtO/H9J7fJBeP+CQEoaI62ozn6O0AhDr8g0ZXNADZ9o0MZnjcWAlvqZ52n6Piz bQMb8vEqX1WwaJj5tV48dnsAuzc3KDsA/p9iHTRtUJvZho4aWSSqxfCFC0cFkxpaairC VJmfznssoHogjcKI5fNNYrvZU0GR2OTs06qDoIjB8GTioMXkbncQHJFeVPkGCvbF/4th 0hLKQm5rBgtjwLHFmfR5YnuMynz5Y/puqm2lMCZodC3x/bM0/IRMIdtVmg/YdI6wc4mm NDTjgA3dOzVwJsAtA8e5cZziOsCjUYHV/3nIFtAbhTZHRYcdE+PEX1Xz/i/Y8LrCzH8G OYRQ== X-Gm-Message-State: AOJu0YxP5BMPk5Vph1gZ4bpEZAwhkcnf3bsjNDhJzrFVq8wN7ARbzcjF 9apDyh+y/769MhSk3VVWqXlBNhzf5wxxYjMGx0nc6uH2fynmP0zQPvArHzKBzQ== X-Gm-Gg: ASbGncuQQ2ag2ypb7K8GWmigMIImX3ryBMezZYaNiqIe/AvqSOJi8qiVQFx7ANx4Lcw Nv+/usNyiKuXKc9s52zXNKlNJEgKsTAVcrUi8y6bFWy4BGBvblNStezZAhLrLrXFD3gSX0FVRwh +L/NVjnl/HiYCYDNe8fUK2848JwJyDMJ3f2hqKpk3EJ/qUWn4jlaokzDeXnPkDhaEn2rymnqerM BsXhDmLy3r0msmROl9iofiyDI54oEiiAuKDKvGM1liILGVIK+jRxn7MM/A9GPlzfhRWx0LJi3fI AE3EBa2ZghR9FQ== X-Google-Smtp-Source: AGHT+IEhLlPSnIfCbdSyRkSFavGrlbdk7991Vt5KnZNDYypLVTmxMOqp+mXyF9rvWv8yrh4noI5Axg== X-Received: by 2002:a05:6214:2401:b0:6d3:6859:c070 with SMTP id 6a1803df08f44-6d43778e143mr97927116d6.5.1732208574849; Thu, 21 Nov 2024 09:02:54 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d438133c52sm25783676d6.102.2024.11.21.09.02.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 09:02:54 -0800 (PST) Message-ID: <16411b6f-3e1d-4d52-a047-8c322774ec8c@broadcom.com> Date: Thu, 21 Nov 2024 09:02:49 -0800 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] pm: cpupower: Makefile: Allow overriding cross-compiling env params To: Peng Fan , "Peng Fan (OSS)" , Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20240919-pm-v2-0-0f25686556b5@nxp.com> <20240919-pm-v2-2-0f25686556b5@nxp.com> <48c0adb5-4ae8-48bc-8e83-3d1c413f6861@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/21/24 04:40, Peng Fan wrote: >> Subject: Re: [PATCH v2 2/2] pm: cpupower: Makefile: Allow overriding >> cross-compiling env params >> >> Hi Peng, >> >> On 9/19/2024 5:08 AM, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> Allow overriding the cross-comple env parameters to make it easier >> for >>> Yocto users. Then cross-compiler toolchains to build cpupower with >>> only two steps: >>> - source (toolchain path)/environment-setup-armv8a-poky-linux >>> - make >> >> This patch breaks the way that buildroot builds cpupower: >> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F >> git.buildroot.net%2Fbuildroot%2Ftree%2Fpackage%2Flinux- >> tools%2Flinux-tool- >> cpupower.mk.in&data=05%7C02%7Cpeng.fan%40nxp.com%7C246da9 >> 2d8b6243d138c808dd09e6d644%7C686ea1d3bc2b4c6fa92cd99c5c3 >> 01635%7C0%7C0%7C638677609234547728%7CUnknown%7CTWFpb >> GZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJX >> aW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat >> a=nL1YUl%2F07Vd8F0GpW7uRqdpZT74avOku1ox9N3%2FFkUg%3D&r >> eserved=0 >> >> and after enabling verbose it becomes clear as to why, see below: >> >> >>> linux-tools Configuring >> >>> linux-tools Building >> GIT_DIR=. >> PATH="/local/users/fainelli/buildroot- >> upstream/output/arm/host/bin:/local/users/fainelli/buildroot- >> upstream/output/arm/host/sbin:/projects/firepath/tools/bin:/home/ff >> 944844/bin:/home/ff944844/.local/bin:/opt/stblinux/bin:/usr/local/sb >> in:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/ga >> mes:/snap/bin:/opt/toolchains/metaware-vctools-0.4.1/bin/" >> /usr/bin/make -j97 >> CROSS=/local/users/fainelli/buildroot- >> upstream/output/arm/host/bin/arm-linux- >> CPUFREQ_BENCH=false NLS=false LDFLAGS="-L. >> -L/local/users/fainelli/buildroot-upstream/output/arm/target/usr/lib" >> DEBUG=false V=1 -C >> /local/users/fainelli/buildroot-upstream/output/arm/build/linux- >> custom/tools >> cpupower >> mkdir -p power/cpupower && /usr/bin/make subdir=power/cpupower >> --no-print-directory -C power/cpupower cc -DVERSION=\"6.12.0\" - >> DPACKAGE=\"cpupower\" >> -DPACKAGE_BUGREPORT=\"linux-pm@vger.kernel.org\" - >> D_GNU_SOURCE -pipe -Wall -Wchar-subscripts -Wpointer-arith -Wsign- >> compare -Wno-pointer-sign -Wdeclaration-after-statement -Wshadow - >> Os -fomit-frame-pointer -fPIC -o lib/cpufreq.o -c lib/cpufreq.c > > You are building on an ARM host? Or you are cross compiling > with cc is actually arm gcc? This is cross compiling targeting ARM, which is why CROSS is set to ../arm-linux- > >> >> Here we use cc, aka host compiler, rather than $(CROSS)gcc as we >> should, so we are no longer cross compiling at all. > > I not understand. CROSS was set, but using cc to compile for host? See below. > >> >> The issue is the use of the lazy set if absent for *all* of CC, LD, AR, STRIP, >> RANLIB, rather than just for CROSS. The following fixes it for me: >> >> diff --git a/tools/power/cpupower/Makefile >> b/tools/power/cpupower/Makefile index >> 175004ce44b2..96bb1e5f3970 100644 >> --- a/tools/power/cpupower/Makefile >> +++ b/tools/power/cpupower/Makefile >> @@ -87,11 +87,11 @@ INSTALL_SCRIPT = ${INSTALL} -m 644 >> # to something more interesting, like "arm-linux-". If you want >> # to compile vs uClibc, that can be done here as well. >> CROSS ?= #/usr/i386-linux-uclibc/usr/bin/i386-uclibc- >> -CC ?= $(CROSS)gcc >> -LD ?= $(CROSS)gcc >> -AR ?= $(CROSS)ar >> -STRIP ?= $(CROSS)strip >> -RANLIB ?= $(CROSS)ranlib >> +CC = $(CROSS)gcc >> +LD = $(CROSS)gcc >> +AR = $(CROSS)ar >> +STRIP = $(CROSS)strip >> +RANLIB = $(CROSS)ranlib > > The ? is just allow to override CC/LD/AR.., so in your env, > CC is set, but should not be used for cpupower compling? Adding debug to show the origin of the CC variable shows the following: CROSS=/local/users/fainelli/buildroot-upstream/output/arm/host/bin/arm-linux- CC origin is (default) and value is (cc) LD origin is (default) and value is (ld) CC=cc LD=ld AR=ar STRIP= RANLIB= See https://www.gnu.org/software/make/manual/html_node/Origin-Function.html#Origin-Function -- Florian