From: "thermal-bot for Dan Carpenter" <tip-bot2@linutronix.de>
To: linux-pm@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
rui.zhang@intel.com, amitk@kernel.org
Subject: [thermal: thermal/next] thermal/drivers/k3_j72xx_bandgap: Fix array underflow in prep_lookup_table()
Date: Thu, 28 Jul 2022 15:41:49 -0000 [thread overview]
Message-ID: <165902290964.15455.15523789691058201166.tip-bot2@tip-bot2> (raw)
In-Reply-To: <YoetjwcOEzYEFp9b@kili>
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: cc67ca28cf8b29245b71e01117927ed2793f35b7
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//cc67ca28cf8b29245b71e01117927ed2793f35b7
Author: Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Fri, 20 May 2022 18:02:39 +03:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 28 Jul 2022 17:29:48 +02:00
thermal/drivers/k3_j72xx_bandgap: Fix array underflow in prep_lookup_table()
This while loop exits with "i" set to -1 and so then it sets:
derived_table[-1] = derived_table[0] - 300;
There is no need for this assignment at all. Just delete it.
Fixes: 72b3fc61c752 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YoetjwcOEzYEFp9b@kili
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/k3_j72xx_bandgap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
index 3a35aa3..27d4cae 100644
--- a/drivers/thermal/k3_j72xx_bandgap.c
+++ b/drivers/thermal/k3_j72xx_bandgap.c
@@ -151,8 +151,6 @@ static int prep_lookup_table(struct err_values *err_vals, int *ref_table)
/* 300 milli celsius steps */
while (i--)
derived_table[i] = derived_table[i + 1] - 300;
- /* case 0 */
- derived_table[i] = derived_table[i + 1] - 300;
}
/*
prev parent reply other threads:[~2022-07-28 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 15:02 [PATCH] thermal: k3_j72xx_bandgap: Fix array underflow in prep_lookup_table() Dan Carpenter
2022-05-20 15:25 ` Daniel Lezcano
2022-05-21 6:56 ` Dan Carpenter
2022-05-21 7:04 ` Dan Carpenter
2022-07-28 15:41 ` thermal-bot for Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165902290964.15455.15523789691058201166.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=amitk@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox