From: Miles Chen <miles.chen@mediatek.com>
To: <linus.walleij@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<sre@kernel.org>, <trix@redhat.com>
Subject: Re: [PATCH] power: supply: ab8500: remove unused static local variable
Date: Fri, 12 Aug 2022 15:53:15 +0800 [thread overview]
Message-ID: <1660290795-612-1-git-send-email-miles.chen@mediatek.com> (raw)
In-Reply-To: <CACRpkdafsWC4VM4c623Q2prkG4uaQPpY0fUkM0wbmWqM0J4TFQ@mail.gmail.com>
>> cpp_check reports
>> [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used.
>>
>> From inspection, this variable is never used. So remove it.
>>
>> Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers")
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
>Thanks Tom!
>Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
>Yours,
>Linus Walleij
Hi Sebastian,
It looks like that this patch is not in linux-next 20220812
and I can still observe this build error with ARCH=arm, defconfig=allyesconfig.
Would you pick up this fix, please?
Thanks,
Miles
next prev parent reply other threads:[~2022-08-12 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 2:27 [PATCH] power: supply: ab8500: remove unused static local variable Tom Rix
2022-07-19 7:57 ` Linus Walleij
2022-08-12 7:53 ` Miles Chen [this message]
2022-08-17 1:57 ` chenlifu
2022-08-17 2:31 ` chenlifu
2022-09-11 12:34 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660290795-612-1-git-send-email-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox