Re: [PATCH v5 00/33] New thermal OF code

Daniel Lezcano
2022-08-10T08:26:57Z

Hi Michael,

On 10/08/2022 10:01, Michael Walle wrote:
> Hi Daniel, >
> Am 2022-08-09 10:23, schrieb Daniel Lezcano:
>>> On my second board
>>> (arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts). I get
>>> the
>>> following error:
>>>
>>> [    6.292819] thermal_sys: Unable to find thermal zones description
>>> [    6.298872] thermal_sys: Failed to find thermal zone for hwmon id=0
>>> [    6.305375] lan966x-hwmon e2010180.hwmon: error -EINVAL: failed to
>>> register hwmon device
>>> [    6.313508] lan966x-hwmon: probe of e2010180.hwmon failed with
>>> error -22
>>>
>>> Again, is there seems to be something missing in the device tree. For
>>> this
>>> board a device tree change should be easily doable, as it is still in
>>> development.
>>
>> Logically with the fixes I've send these errors should have gone. Just
>> a pr_info should appear "... not attached to any thermal zone".
>>
>> If I'm correct, without or with the changes (new thermal OF code +
>> fixes), the hwmon message is the same and the hwmon thermal zone is
>> not created. So no regression hopefully.
>>
>> Is it possible to check that?
>
> Yes, I'm no more seeing any error messages and the device
> is probed successfully. Both on the kswitch board as well as on
> the sl28 board.

Great! thanks for testing

-- Daniel

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |