From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tony Lindgren <tony@atomide.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-pm@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
nsekhar@ti.com, nm@ti.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs
Date: Thu, 07 Apr 2016 23:25:50 +0200 [thread overview]
Message-ID: <1664339.h6rI5IB9Xd@vostro.rjw.lan> (raw)
In-Reply-To: <20160407175600.GN16484@atomide.com>
On Thursday, April 07, 2016 10:56:01 AM Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [160406 04:47]:
> > Now wakeirq stops working for device if wakeup option for
> > this device will be reconfigured through sysfs, like:
> >
> > echo disabled > /sys/devices/platform/extcon_usb1/power/wakeup
> > echo enabled > /sys/devices/platform/extcon_usb1/power/wakeup
> >
> > Once above set of commands is executed the device's wakeup_source
> > opject will be recreated and dev->power.wakeup->wakeirq field will
> > contain NULL. As result, device_wakeup_arm_wake_irqs() will not arm
> > wakeirq for the affected device.
> >
> > Hece, lets try to fix it in the following way:
> > check for dev->wakeirq field when device_wakeup_attach() is called
> > and if !NULL re-attach wakeirq to the device
>
> Yeah I think that's all there is to it, thanks for fixing it:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Applied, thanks!
prev parent reply other threads:[~2016-04-07 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 11:45 [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs Grygorii Strashko
2016-04-07 17:56 ` Tony Lindgren
2016-04-07 21:25 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1664339.h6rI5IB9Xd@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=grygorii.strashko@ti.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox