From: Stefan Wahren <stefan.wahren@i2se.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
rjui@broadcom.com, sbranden@broadcom.com,
kernel@martin.sperl.org, rafal@milecki.pl, eric@anholt.net,
rui.zhang@intel.com, bcm-kernel-feedback-list@broadcom.com,
f.fainelli@gmail.com, edubezval@gmail.com
Cc: linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'
Date: Fri, 23 Jun 2017 22:25:45 +0200 (CEST) [thread overview]
Message-ID: <1667598657.325840.1498249545131@email.1und1.de> (raw)
In-Reply-To: <20170623194435.8094-1-christophe.jaillet@wanadoo.fr>
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> hat am 23. Juni 2017 um 21:44 geschrieben:
>
>
> 'tz' is a valid pointer at this point, so calling PTR_ERR on it is
> pointless.
> This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above.
> So remove it. 'err' is already the error we want to report.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, but Dan Carpenter already send a fix for this.
next prev parent reply other threads:[~2017-06-23 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 19:44 [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' Christophe JAILLET
2017-06-23 20:25 ` Stefan Wahren [this message]
2017-07-01 2:55 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667598657.325840.1498249545131@email.1und1.de \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=edubezval@gmail.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox