From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: sre@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
tony@atomide.com, philipp@uvos.xyz,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Subject: [PATCH 2/3] power: supply: cpcap-battery: Fix battery identification
Date: Sat, 5 Nov 2022 13:25:43 +0200 [thread overview]
Message-ID: <1667647544-12945-3-git-send-email-ivo.g.dimitrov.75@gmail.com> (raw)
In-Reply-To: <1667647544-12945-1-git-send-email-ivo.g.dimitrov.75@gmail.com>
Use the same logic to identify genuine batteries as Android does.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
drivers/power/supply/cpcap-battery.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 8869067..ca6ee2b 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -422,7 +422,7 @@ static int cpcap_battery_cc_to_ua(struct cpcap_battery_ddata *ddata,
static int cpcap_battery_match_nvmem(struct device *dev, const void *data)
{
- if (strcmp(dev_name(dev), "89-500029ba0f73") == 0)
+ if (strncmp(dev_name(dev), "89-500", 6) == 0)
return 1;
else
return 0;
@@ -439,10 +439,19 @@ static void cpcap_battery_detect_battery_type(struct cpcap_battery_ddata *ddata)
if (IS_ERR_OR_NULL(nvmem)) {
ddata->check_nvmem = true;
dev_info_once(ddata->dev, "Can not find battery nvmem device. Assuming generic lipo battery\n");
- } else if (nvmem_device_read(nvmem, 2, 1, &battery_id) < 0) {
- battery_id = 0;
- ddata->check_nvmem = true;
- dev_warn(ddata->dev, "Can not read battery nvmem device. Assuming generic lipo battery\n");
+ } else {
+ char buf[24];
+
+ if (nvmem_device_read(nvmem, 96, 4, buf) < 0 ||
+ strncmp(buf, "COPR", 4) != 0 ||
+ nvmem_device_read(nvmem, 104, 24, buf) < 0 ||
+ strncmp(buf, "MOTOROLA E.P CHARGE ONLY", 24) != 0 ||
+ nvmem_device_read(nvmem, 2, 1, &battery_id) < 0) {
+ battery_id = 0;
+ ddata->check_nvmem = true;
+ dev_warn(ddata->dev, "Can not read battery nvmem device. Assuming generic lipo battery\n");
+ }
+
}
switch (battery_id) {
--
1.9.1
next prev parent reply other threads:[~2022-11-05 11:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 11:25 [PATCH v2 0/3] power: supply: cpcap-battery improvements Ivaylo Dimitrov
2022-11-05 11:25 ` [PATCH 1/3] power: cpcap-battery: Do not issue low signal too frequently Ivaylo Dimitrov
2022-11-10 15:55 ` Sebastian Reichel
2022-11-10 18:13 ` Ivaylo Dimitrov
2022-11-11 6:15 ` Dan Carpenter
2022-11-05 11:25 ` Ivaylo Dimitrov [this message]
2022-11-10 16:05 ` [PATCH 2/3] power: supply: cpcap-battery: Fix battery identification Sebastian Reichel
2022-11-10 16:50 ` Ivaylo Dimitrov
2022-11-15 13:49 ` Tony Lindgren
2022-11-15 15:41 ` Ivaylo Dimitrov
2022-11-17 4:53 ` Tony Lindgren
2022-11-17 8:15 ` Carl Klemm
2022-11-22 7:15 ` Tony Lindgren
2022-11-05 11:25 ` [PATCH 3/3] power: supply: cpcap_battery: Read battery parameters from nvram Ivaylo Dimitrov
2022-12-05 20:28 ` Ivaylo Dimitrov
-- strict thread matches above, loose matches on Subject: below --
2022-11-01 19:53 [PATCH 0/3] power: supply: cpcap-battery improvements Ivaylo Dimitrov
2022-11-01 19:53 ` [PATCH 2/3] power: supply: cpcap-battery: Fix battery identification Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667647544-12945-3-git-send-email-ivo.g.dimitrov.75@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=philipp@uvos.xyz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).