From: Rob Herring <robh@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
devicetree@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
linux-kernel@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: thermal-idle: Fix example paths
Date: Wed, 16 Nov 2022 14:14:49 -0600 [thread overview]
Message-ID: <166862968776.815892.2892622787261492597.robh@kernel.org> (raw)
In-Reply-To: <20221111162729.3381835-1-robh@kernel.org>
On Fri, 11 Nov 2022 10:27:29 -0600, Rob Herring wrote:
> The reference by path (&{/cpus/cpu@101/thermal-idle}) in the example causes
> an error with new version of dtc:
>
> FATAL ERROR: Can't generate fixup for reference to path &{/cpus/cpu@100/thermal-idle}
>
> This is because the examples are built as an overlay and absolute paths
> are not valid as references must be by label. The path was also not
> resolvable because, by default, examples are placed under 'example-N'
> nodes.
>
> As the example contains top-level nodes, the root node must be explicit for
> the example to be extracted as-is. This changes the indentation for the
> whole example, but the existing indentation is a mess of of random amounts.
> Clean this up to be 4 spaces everywhere.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> The dtc update is in my tree, so I'd prefer to take this via the DT
> tree.
>
> .../bindings/thermal/thermal-idle.yaml | 154 +++++++++---------
> 1 file changed, 80 insertions(+), 74 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2022-11-16 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 16:27 [PATCH] dt-bindings: thermal: thermal-idle: Fix example paths Rob Herring
2022-11-16 20:14 ` Rob Herring [this message]
2022-12-06 17:14 ` Daniel Lezcano
2022-12-06 17:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166862968776.815892.2892622787261492597.robh@kernel.org \
--to=robh@kernel.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox