From: "thermal-bot for Johan Hovold" <tip-bot2@linutronix.de>
To: linux-pm@vger.kernel.org
Cc: Johan Hovold <johan+linaro@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Andrew Halaney <ahalaney@redhat.com>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org
Subject: [thermal: thermal/next] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message
Date: Fri, 09 Dec 2022 15:26:28 -0000 [thread overview]
Message-ID: <167059958829.4906.9817713570611553877.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20221102152630.696-1-johan+linaro@kernel.org>
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 807efb7102e8d22b61cd400495f9478a110badd2
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//807efb7102e8d22b61cd400495f9478a110badd2
Author: Johan Hovold <johan+linaro@kernel.org>
AuthorDate: Wed, 02 Nov 2022 16:26:30 +01:00
Committer: Daniel Lezcano <daniel.lezcano@kernel.org>
CommitterDate: Thu, 08 Dec 2022 14:30:44 +01:00
thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message
Drivers should not be logging errors on probe deferral. Switch to using
dev_err_probe() to log failures when parsing the devicetree to avoid
errors like:
qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517
when a channel is not yet available.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20221102152630.696-1-johan+linaro@kernel.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
---
drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
index 1b2c43e..88462a4 100644
--- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
+++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
@@ -1030,10 +1030,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
return irq;
ret = adc_tm5_get_dt_data(adc_tm, node);
- if (ret) {
- dev_err(dev, "get dt data failed: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "get dt data failed\n");
ret = adc_tm->data->init(adc_tm);
if (ret) {
prev parent reply other threads:[~2022-12-09 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 15:26 [PATCH] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message Johan Hovold
2022-11-02 16:10 ` Andrew Halaney
2022-11-02 16:23 ` Manivannan Sadhasivam
2022-11-30 6:58 ` Johan Hovold
2022-12-04 16:35 ` Daniel Lezcano
2022-12-09 15:26 ` thermal-bot for Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167059958829.4906.9817713570611553877.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=ahalaney@redhat.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mani@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox