From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad Date: Sat, 04 Jan 2014 15:38:31 +0100 Message-ID: <1676077.d8A9e8eo7M@vostro.rjw.lan> References: <2513222.AheLcigoE8@vostro.rjw.lan> <52C7C7EE.1070407@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <52C7C7EE.1070407@redhat.com> Sender: cpufreq-owner@vger.kernel.org To: Paolo Bonzini Cc: Gleb Natapov , Dirk Brandewie , Kashyap Chamarthy , Josh Boyer , One Thousand Gnomes , Viresh Kumar , "cpufreq@vger.kernel.org" , Linux PM list , "Linux-Kernel@Vger. Kernel. Org" , "Richard W.M. Jones" List-Id: linux-pm@vger.kernel.org On Saturday, January 04, 2014 09:35:58 AM Paolo Bonzini wrote: > Il 03/01/2014 23:46, Rafael J. Wysocki ha scritto: > > Well, fixing the KVM bug is surely welcome. > > > > That said, adding checks to ensure that your assumptions are valid is rarely > > wrong, especially if they are done once per kernel boot. And the kernel only > > should panic if it cannot continue to run, which isn't the case here. > > I agree, but I suspect even your check is already late. Well, it's just a sanity check and it makes the problem go away for the reporter. > Your patch is welcome but perhaps it should have a WARN_ON too. It has been pulled in already, so the WARN_ON() can only be added via a separate patch now. Would you like to prepare that patch? Rafael