From: Thomas Renninger <trenn@suse.com>
To: Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Cc: Shuah Khan <shuah@kernel.org>,
linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 29/29] tools: Avoid comma separated statements
Date: Wed, 26 Aug 2020 18:13:30 +0200 [thread overview]
Message-ID: <1696974.unB1bf7olB@c100> (raw)
In-Reply-To: <7b78e43a01865ec0c296ad9acad0616a6c2c3b86.camel@perches.com>
Am Mittwoch, 26. August 2020, 16:45:24 CEST schrieb Joe Perches:
> On Wed, 2020-08-26 at 11:30 +0200, Thomas Renninger wrote:
> > Hi,
> >
> Read the block immediately below that too:
>
> "This does not apply if only one branch of a conditional statement is a
> single statement; in the latter case use braces in both branches:"
Then +1 from here.
> > Afaik there isn't a specific tag, but having:
> > cleanup only: No functional change
> >
> > in the changelog would be nice for people looking for fixes to backport.
>
> This is not a fix, so it's not for backporting.
Mentioning that in the changelog explicitly or even in the title - cleanup
only
is nice imho, but should definitely not be the reason for re-posting.
Thanks for doing this,
Thomas
next prev parent reply other threads:[~2020-08-26 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
2020-08-25 4:56 ` [PATCH 29/29] tools: Avoid " Joe Perches
2020-08-26 9:30 ` Thomas Renninger
2020-08-26 14:45 ` Joe Perches
2020-08-26 16:13 ` Thomas Renninger [this message]
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1696974.unB1bf7olB@c100 \
--to=trenn@suse.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).