From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6F8C433E1 for ; Wed, 26 Aug 2020 16:14:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39FCE22B4B for ; Wed, 26 Aug 2020 16:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbgHZQOE (ORCPT ); Wed, 26 Aug 2020 12:14:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:50782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727814AbgHZQNd (ORCPT ); Wed, 26 Aug 2020 12:13:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0CD5FB6FA; Wed, 26 Aug 2020 16:14:03 +0000 (UTC) From: Thomas Renninger To: Jiri Kosina , linux-kernel@vger.kernel.org, Joe Perches Cc: Shuah Khan , linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 29/29] tools: Avoid comma separated statements Date: Wed, 26 Aug 2020 18:13:30 +0200 Message-ID: <1696974.unB1bf7olB@c100> In-Reply-To: <7b78e43a01865ec0c296ad9acad0616a6c2c3b86.camel@perches.com> References: <6011591.XMClsHuqKX@c100> <7b78e43a01865ec0c296ad9acad0616a6c2c3b86.camel@perches.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Am Mittwoch, 26. August 2020, 16:45:24 CEST schrieb Joe Perches: > On Wed, 2020-08-26 at 11:30 +0200, Thomas Renninger wrote: > > Hi, > > > Read the block immediately below that too: > > "This does not apply if only one branch of a conditional statement is a > single statement; in the latter case use braces in both branches:" Then +1 from here. > > Afaik there isn't a specific tag, but having: > > cleanup only: No functional change > > > > in the changelog would be nice for people looking for fixes to backport. > > This is not a fix, so it's not for backporting. Mentioning that in the changelog explicitly or even in the title - cleanup only is nice imho, but should definitely not be the reason for re-posting. Thanks for doing this, Thomas