From: Thomas Renninger <trenn@suse.com>
To: shuah@kernel.org, Martin Kaistra <martin.kaistra@linutronix.de>
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpupower: speed up generating git version string
Date: Thu, 20 Aug 2020 12:27:46 +0200 [thread overview]
Message-ID: <1698400.ZyLY7WPuaR@c100> (raw)
In-Reply-To: <20200812094912.2648-1-martin.kaistra@linutronix.de>
Am Mittwoch, 12. August 2020, 11:49:12 CEST schrieb Martin Kaistra:
> The variable VERSION is expanded for every use of CFLAGS. This causes
> "git describe" to get called multiple times on the kernel tree, which
> can be quite slow.
>
> The git revision does not change during build, so we can use simple
> variable expansion to set VERSION.
Good catch, thanks!
Acked-by: Thomas Renninger <trenn@suse.de>
next prev parent reply other threads:[~2020-08-20 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 9:49 [PATCH] cpupower: speed up generating git version string Martin Kaistra
2020-08-20 10:27 ` Thomas Renninger [this message]
2020-08-20 19:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1698400.ZyLY7WPuaR@c100 \
--to=trenn@suse.com \
--cc=linux-pm@vger.kernel.org \
--cc=martin.kaistra@linutronix.de \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).