From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Jernej Skrabec <jernej@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
linux-sunxi@lists.linux.dev,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers
Date: Thu, 10 Jul 2025 17:30:34 -0500 [thread overview]
Message-ID: <175218663372.4188922.16230112848863911974.robh@kernel.org> (raw)
In-Reply-To: <20250709155343.3765227-2-wens@kernel.org>
On Wed, 09 Jul 2025 23:53:40 +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> The A523 PPU is likely the same kind of hardware seen on previous SoCs.
>
> The A523 PCK600, as the name suggests, is likely a customized version
> of ARM's PCK-600 power controller. Comparing the BSP driver against
> ARM's PPU datasheet shows that the basic registers line up, but
> Allwinner's hardware has some additional delay controls in the reserved
> register range. As such it is likely not fully compatible with the
> standard ARM version.
>
> Document A523 PPU and PCK600 compatibles.
>
> Also reorder the compatible string entries so they are grouped and
> ordered by family first, then by SoC model.
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> ---
> Changes since v1:
> - Re-order compatible string entries
> - Fix name of header file to match compatible string
> ---
> .../bindings/power/allwinner,sun20i-d1-ppu.yaml | 4 +++-
> .../power/allwinner,sun55i-a523-pck-600.h | 15 +++++++++++++++
> .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
> 3 files changed, 30 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck-600.h
> create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-07-10 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 15:53 [PATCH v2 0/4] allwinner: a523: Add power controllers Chen-Yu Tsai
2025-07-09 15:53 ` [PATCH v2 1/4] dt-bindings: power: Add A523 PPU and PCK600 " Chen-Yu Tsai
2025-07-10 22:30 ` Rob Herring (Arm) [this message]
2025-07-09 15:53 ` [PATCH v2 2/4] pmdomain: sunxi: sun20i-ppu: add A523 support Chen-Yu Tsai
2025-07-09 15:53 ` [PATCH v2 3/4] pmdomain: sunxi: add driver for Allwinner A523's PCK-600 power controller Chen-Yu Tsai
2025-07-09 23:46 ` Andre Przywara
2025-07-10 4:14 ` Chen-Yu Tsai
2025-07-10 22:55 ` Andre Przywara
2025-07-09 15:53 ` [PATCH v2 4/4] arm64: dts: allwinner: a523: Add power controller device nodes Chen-Yu Tsai
2025-07-09 21:23 ` [PATCH v2 0/4] allwinner: a523: Add power controllers Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175218663372.4188922.16230112848863911974.robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox