From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FD664A21; Sat, 20 Sep 2025 05:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758344806; cv=none; b=CzJ5O4rvz23a2RT+g4eK4jEOj3wUr/WR03LskyR78mQgFoSa0rySfPqVza9vRiCdplSD2k6t8RMtBqVcAPocUcYGCB9oLOMxC4gc69ZBZUVGgXtvgP3KIohrsoCGVH4SRcwu0p0/WVLPmdoyDRJsTEhMfll7s0rFTkDRewbV6tY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758344806; c=relaxed/simple; bh=0UDfmZ7DaFZLTqzi59DgWOG0qhddX+UAkuVNJQTlmKQ=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=WrMpLawEVfa11E40d3danWwU7+BQ/yrqdnOpnCrq9kS7FNAa59vW3KKxiVoP4U0jmkJRYFw+oDto+S/YF16ExcHSNzyJWz2DH/Y2BS9Ilz34zq1X1MZ70OTpfLLkSRKbrK6ph+DUzC/w8GVJWQbwhvOQb8m6Q2maUmVc6G+T2qE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r8csHsX3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r8csHsX3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92D92C4CEEB; Sat, 20 Sep 2025 05:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758344805; bh=0UDfmZ7DaFZLTqzi59DgWOG0qhddX+UAkuVNJQTlmKQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=r8csHsX35fQg5mQ46THNN6En77PyJ8zJJ+Evlg4sO9JjPNoGFZGFxhnil5hO7rjiP jXDcBh4nQaWIvR2PInQuH6NpNK+rDtnhSXpsVFi2TUAe3AVkB/VTzk6Kq7gV1T41a4 YLBJEsw7zEzJuimXE/j6gfHtU8amKJB97pHHvOi3Owl1naqchh/VIcT5rnkGSIKxhi fEZyY6YV7FCW0wgZV2mAJ61ygSE0xjDIflPdwKzxcs3XWmDugYd9y7GgpGO206i4TY nzR7LtRzvACwJPmy8/KS4nfboL0bUunZYiLJts9WEPvdKPmL8iDoOE39bgIJ5+UP6k fb3/Be+H5wTHg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <3D936C1B-FBA9-4964-859C-84BB665BBE3B@collabora.com> References: <20250910-clk-type-state-v2-0-1b97c11bb631@collabora.com> <20250910-clk-type-state-v2-1-1b97c11bb631@collabora.com> <3D936C1B-FBA9-4964-859C-84BB665BBE3B@collabora.com> Subject: Re: [PATCH v2 1/2] rust: clk: implement Send and Sync From: Stephen Boyd Cc: Michael Turquette , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rafael J. Wysocki , Viresh Kumar , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org To: Boqun Feng , Daniel Almeida Date: Fri, 19 Sep 2025 22:06:44 -0700 Message-ID: <175834480479.4354.6269916774389395049@lazor> User-Agent: alot/0.11 Quoting Daniel Almeida (2025-09-10 11:47:30) > Hi Boqun, >=20 > > On 10 Sep 2025, at 14:49, Boqun Feng wrote: > >=20 > > On Wed, Sep 10, 2025 at 02:28:27PM -0300, Daniel Almeida wrote: > >> From: Alice Ryhl > >>=20 > >> These traits are required for drivers to embed the Clk type in their o= wn > >> data structures because driver data structures are usually required to > >> be Send. See e.g. [1] for the kind of workaround that drivers currently > >> need due to lacking this annotation. > >>=20 > >> Link: https://lore.kernel.org/rust-for-linux/20250812-tyr-v2-1-9e0f3dc= 9da95@collabora.com/ [1] > >> Signed-off-by: Daniel Almeida > >> Signed-off-by: Alice Ryhl > >> Reviewed-by: Danilo Krummrich > >> Acked-by: Viresh Kumar > >> Reviewed-by: Daniel Almeida > >=20 > > This tag list looks a bit weird to me. Why is there a SoB from you > > before Alice's SoB? At least for the usage I'm familiar with, outside > > the case of Co-developed-bys, multiple SoBs is used for recording how > > the patches are routed. For example, if I have a patch that has my SoB > > and I send it to you, you queue in your tree and then send out to other > > maintainers for merging, in general you would put your SoB after mine in > > that case. But I don't think that's case here? Alice's patch has only > > her SoB: > >=20 > > https://lore.kernel.org/rust-for-linux/20250904-clk-send-sync-v1-1-48d0= 23320eb8@google.com/ > >=20 > > What's the intention of the SoB tag here? > >=20 > > Otherwise the patch looks good to me. If we get the tag list resolved, > > feel free to add: > >=20 > > Reviewed-by: Boqun Feng > >=20 > > Regards, > > Boqun > >=20 >=20 > You have to include your SOB when submitting patches from others. >=20 > This is something I tend to forget often, so I made sure it was there. The > order may be indeed off though. Yes the order is wrong. The first SoB should be the commit author.