Re: [PATCH v3 01/11] devfreq: tegra30-devfreq: add support for Tegra114

Svyatoslav Ryhel
2025-11-11T13:35:10Z

вт, 11 лист. 2025 р. о 10:55 Mikko Perttunen <mperttunen@nvidia.com> пише:
>
> On Monday, September 15, 2025 5:01 PM Svyatoslav Ryhel wrote:
> > Lets add Tegra114 support to activity monitor device as a preparation to
> > upcoming EMC controller support.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > drivers/devfreq/tegra30-devfreq.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> > index 8ea5b482bfb3..d976077d4757 100644
> > --- a/drivers/devfreq/tegra30-devfreq.c
> > +++ b/drivers/devfreq/tegra30-devfreq.c
> > @@ -980,6 +980,7 @@ static const struct tegra_devfreq_soc_data tegra30_soc = {
> >
> > static const struct of_device_id tegra_devfreq_of_match[] = {
> > { .compatible = "nvidia,tegra30-actmon", .data = &tegra30_soc, },
> > + { .compatible = "nvidia,tegra114-actmon", .data = &tegra124_soc, },
> > { .compatible = "nvidia,tegra124-actmon", .data = &tegra124_soc, },
> > { },
> > };
> >
>
> Looking at my copy of L4T r21, the EMC count_weight should be 256 on Tegra114, while it is 4*256 on Tegra124, so different SoC data should be used. (I haven't checked if anything else is different)
>

You are correct, tegra114 seems to use 1 EMC clock per transaction. I
will move and expand comment from tegra124 entry regarding
count_weight to include info about all 3 supported entries if you
don't mind.

I have a question regarding tegra_devfreq_device_config to be used
with tegra114. From tegratab kernel I have, existing
tegra124_device_configs configuration seems to fit tegra114, may you
confirm this? Or, if L4T r21 you use, uses different values, may you
provide those to fill up tegra_devfreq_device_config for tegra114.

> Cheers,
> Mikko
>
>