From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze() Date: Thu, 21 May 2015 03:02:36 +0200 Message-ID: <1773599.T1QStsTFTH@vostro.rjw.lan> References: <1432046953-12945-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1432046953-12945-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomeu Vizoso Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lorenzo Pieralisi , "Rafael J. Wysocki" , Russell King , Stephen Warren , Thierry Reding , Alexandre Courbot , Kukjin Kim , Ingo Molnar , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pm@vger.kernel.org On Tuesday, May 19, 2015 04:49:12 PM Tomeu Vizoso wrote: > This callback is expected to do the same as enter() but it has to > guarantee that interrupts aren't enabled at any point in its execution, > as the tick is frozen. > > It will be called when the system goes to suspend-to-idle and will > reduce power usage because CPUs won't be awaken for unnecessary IRQs. > > By setting the CPUIDLE_FLAG_TIMER_STOP flag, we can reuse the same code > for both the enter() and enter_freeze() callbacks. > > Signed-off-by: Tomeu Vizoso > Cc: Rafael J. Wysocki Makes sense to me, but I suppose it should go in via arm-soc. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.