Re: [PATCH] PowerCap: Error with option -Werror=format-security

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Monday, November 04, 2013 11:51:25 AM Kees Cook wrote:
> On Mon, Nov 4, 2013 at 8:53 AM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > Fix compile error with gcc option: -Werror=format-security for
> > dev_set_name(&control_type->dev, name)
> > Changed to
> > dev_set_name(&control_type->dev, "%s", name);
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > ---
> >  drivers/powercap/powercap_sys.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> > index 21814f9..8d0fe43 100644
> > --- a/drivers/powercap/powercap_sys.c
> > +++ b/drivers/powercap/powercap_sys.c
> > @@ -625,7 +625,7 @@ struct powercap_control_type *powercap_register_control_type(
> >         control_type->ops = ops;
> >         INIT_LIST_HEAD(&control_type->node);
> >         control_type->dev.class = &powercap_class;
> > -       dev_set_name(&control_type->dev, name);
> > +       dev_set_name(&control_type->dev, "%s", name);
> >         result = device_register(&control_type->dev);
> >         if (result) {
> >                 if (control_type->allocated)
> > --
> > 1.7.11.7
> 
> Thanks for getting this fixed!
> 
> Acked-by: Kees Cook <keescook@chromium.org>

Queued up for 3.13, thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.